Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(API): permissive email check in login, reset & verification #6648

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(API): permissive email check in login, reset & verification #6648

wants to merge 2 commits into from

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Oct 1, 2024 •
edited
Loading

Description

In order to not force users to be case sensitive when asking for password reset or resend email verification. When there's multiple emails where the only difference in the local is the capitalized letters, in those cases the users has to be case sensitive.

  • When a user tries to login: fetch all emails in the database case insensitive. If there's only one match, then treat it as the correct email even if they differ in capitalized letters.
  • When a user tries to reset password: fetch all emails in the database case insensitive. If there's only one match, then treat it as the correct email even if they differ in capitalized letters.
  • When a user tries to get a new verification email: fetch all emails in the database case insensitive. If there's only one match, then treat it as the correct email even if they differ in capitalized letters.

Related issues

closes #6570

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this PR does not update server code
  • 🙋 no, because I need help

Screenshots

@kontrollanten kontrollanten marked this pull request as draft October 1, 2024 20:43
@kontrollanten kontrollanten force-pushed the feat-6570-permissive-email-handling branch 2 times, most recently from 77c4d9e to 4134f25 Compare October 2, 2024 05:46
@kontrollanten
feat(API): permissive email check in reset & verification
714d9c4 
In order to not force users to be case sensitive when asking for
password reset or resend email verification. When there's multiple
emails where the only difference in the local is the capitalized
letters, in those cases the users has to be case sensitive.

closes Chocobozzz#6570
@kontrollanten kontrollanten force-pushed the feat-6570-permissive-email-handling branch from 4134f25 to b417ca2 Compare October 2, 2024 07:00
@kontrollanten
feat(API/login): permissive email handling
5e44b71 
Allow case insensitive email when there's no other candidate.

closes Chocobozzz#6570
@kontrollanten kontrollanten force-pushed the feat-6570-permissive-email-handling branch from b417ca2 to 5e44b71 Compare October 2, 2024 07:38
@kontrollanten kontrollanten marked this pull request as ready for review October 2, 2024 08:04
@kontrollanten kontrollanten changed the title feat(API): permissive email check in reset & verification feat(API): permissive email check in login, reset & verification Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some users can't reset their password
1 participant
@kontrollanten