Fix device polling when using ReadProperty class instead of ReadPropertyMultiple
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se_20.11.04 Release 20.11.04
|
Seems like a good catch. When device is defined as RP, it's because it doesn't support read_multiple... or segmentation. A restriction that is following me from the beginning... Hope someday I'll be able to fix this in a better way. In this context, calling read_multiple will generate multiple single reads... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
ReadPropertyandReadPropertyMultiplediffer in their implied signatures for theread_multiplemethod currently - RPM works with a list of point names but RP fails with an error (e.g.Unknown object type : METER) if you pass in a point name.This PR updates the two to behave the same, which fixes device polling for me on a network where segmentation isn't supported.