Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadProperty::read_multiple should populate trends #230

Conversation

gnmerritt
Copy link
Contributor

Ok, another small follow-on to #229 - looks like the point._trend function gets called in the ReadPropertyMultiple version and that's how polling actually populates point.history. So I've copied that logic over to the single read version.

@coveralls
Copy link

coveralls commented Nov 18, 2020

Coverage Status

Coverage decreased (-1.5%) to 45.877% when pulling bff1746 on gnmerritt:readproperty-read-multiple-trend into de367f0 on ChristianTremblay:develop.

@ChristianTremblay
Copy link
Owner

Thank you

@ChristianTremblay ChristianTremblay merged commit 834cbd5 into ChristianTremblay:develop Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants