Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about the change of certain values afects the safe prediction #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning about the change of certain values afects the safe prediction #47

wants to merge 1 commit into from

Conversation

llunaCreixent
Copy link
Member

No description provided.

@adzialocha
Copy link

We should add a warning in the config files next to all the variables which affect the prediction, think there it is more likely to be seen by future us 😅

louilinn
louilinn reviewed May 28, 2021
View reviewed changes
Copy link

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to write what safe address prediction is or take this opportunity to document in the handbook about this too?

@llunaCreixent
Copy link
Member Author

yes! Definitely. We have this in an issue: CirclesUBI/circles-handbook#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louilinn louilinn louilinn left review comments

@adzialocha adzialocha Awaiting requested review from adzialocha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llunaCreixent @adzialocha @louilinn