Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about the change of certain values afects the safe prediction #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning about the change of certain values afects the safe prediction #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion safe_relay_service/relay/services/safe_creation_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ class SafeCreationService:
def __init__(self, gas_station: GasStation, ethereum_client: EthereumClient, redis: Redis,
safe_contract_address: str, proxy_factory_address: str, default_callback_handler: str,
safe_funder_private_key: str, safe_fixed_creation_cost: int):
"""
:warning: Changing the value of any of the parameters of the build_safe_create2_tx function will affect the safe address prediction
"""
self.gas_station = gas_station
self.ethereum_client = ethereum_client
self.redis = redis
Expand Down Expand Up @@ -163,8 +166,8 @@ def predict_address(self, salt_nonce: int, owners: Iterable[str], threshold: int
:param payment_token: Address of the payment token, otherwise `ether` is used
:rtype: str
:raises: InvalidPaymentToken
:warning: Changing the value of any of the parameters of the build_safe_create2_tx function will affect the safe address prediction
"""

payment_token = payment_token or NULL_ADDRESS
payment_token_eth_value = self._get_token_eth_value_or_raise(payment_token)
gas_price: int = self._get_configured_gas_price()
Expand Down