Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke fails on windows #62

Closed
bonfirefan opened this issue Aug 16, 2017 · 7 comments · Fixed by #64
Closed

invoke fails on windows #62

bonfirefan opened this issue Aug 16, 2017 · 7 comments · Fixed by #64

Comments

@bonfirefan
Copy link
Collaborator

bonfirefan commented Aug 16, 2017

invoke runtests
You indicated pty=True, but your platform doesn't support the 'pty' module!

Unfortunately pseudo terminal handling is not available for Windows, and the pty=true flag prevents you from invoking runtests. Most people are probably not doing the frustrating thing of trying to run things in Windows like I am, but just case, I know one solution mentioned was to put in an os check.

jim added a commit to jim/city-scrapers that referenced this issue Aug 16, 2017
@eads
Copy link
Collaborator

eads commented Aug 16, 2017

I looked around a bit and you should be able to do something like:

import sys
# ...
pty = sys.platform != 'win32'
run('pytest', pty=pty)

@eads
Copy link
Collaborator

eads commented Aug 16, 2017

I'm also wondering whether or not to file something against invoke ... I feel like it should warn and skip the pseudo terminal rather than bailing out, but I can see the case for how it works now.

@eads eads closed this as completed in #64 Aug 19, 2017
@easherma
Copy link
Contributor

I ran into similar/other issues with using windows directly. It may or may not be worth it to stub out an issue regarding Windows support/issues?

@bonfirefan were you able to get up and running? Alternative, if you're familiar with using Docker I recently added a Dockerfile that you could use to run on Windows instead

@bonfirefan
Copy link
Collaborator Author

Hey there! I would love to test out the dockerfile - I ended up switching completely to Linux, though!

@bonfirefan
Copy link
Collaborator Author

Big thanks for setting this up, @easherma. I set this up and ran tests fine. Check over the info on the install file to make sure that the process is reflected accurately.

@easherma
Copy link
Contributor

easherma commented Jan 31, 2018 via email

@easherma
Copy link
Contributor

easherma commented Apr 5, 2018

@bonfirefan, btw, when i started using pipenv to manage dependencies this problem completely went away, even on windows!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants