-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pty support for Windows? #561
Comments
Responder itself should be fine, I think the issue is just the use of Is this just a request that we silently change If it's something else, please let me know! |
Hey @bitprophet 👋 Thanks for your quick reply! Sorry I was not clear enough in my original comment! I believe you're correct to say this is specifically a A quick google search yields promising results: winpty and pywinpty 👍 |
That sounds reasonable to investigate, sure! I don't like having certain behaviors "walled off" for certain platforms, if I can help it. I suspect that a pile of additional code might be needed to leverage something like |
I use Invoke extensively but the rest of my colleagues use Windows and there are strange failures on Windows platforms for them (commands failing silently and invoke exiting without any console messages). I am holding out hope that these failures are due to the lack of pty support on Windows and would love to see this change come to fruition. I would also be happy to help with the PR, but I am unfortunately out of my element when it comes to programming around terminals/pty/forking etc. |
winpty, preinstalled in Git Bash, does not fix the issue, it looks like its hardcoded to the OS platform. |
Is there any progress on this? |
[MAINTAINER EDIT: this ticket is now about possibly adding pty support for Windows so that really-wants-a-pty-to-behave-right applications can work there. See this comment.]
The example source code line can be found here.
Implementing this hotfix (setting
pty=False
) resulted in the following output:Thanks in advance for your time! 🙂
The text was updated successfully, but these errors were encountered: