Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when creating a hearing with existing file references, add option for creating new files/images by reference #490

Merged
merged 2 commits into from
May 7, 2024

Commits on May 6, 2024

  1. feat: create images/files by reference, remove copy logic

    Some of the serializers worked with a update-or-copy
    logic instead of update-or-create (as their name would
    imply), which was added in PR #363 (6c97234).
    
    This caused an error whenever you're creating
    a new hearing and have already uploaded a file to a
    section (via the form's file upload functionality).
    Added a test to confirm that this scenario functions
    correctly now.
    
    This removes that copy (or rather, save as copy)
    logic and moves the burden to the consumer of the
    API, i.e. the consumer needs to remove the IDs
    from the data they want to copy.
    
    However, files and images still need a reference
    to the instance they're copied from, so add a
    new field "reference_id" for this. This allows
    the user to create new files or images based
    on existing instances.
    
    In its current state, it's meant for
    "save as new" type of situations.
    This means that if the pk is set for an
    image/file, then it will ignore the
    reference_id, i.e. you cannot update an
    existing instance using reference_id.
    danipran committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a68d958 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d360691 View commit details
    Browse the repository at this point in the history