Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for holiday inclusion/exclusion #84

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Add option for holiday inclusion/exclusion #84

merged 10 commits into from
Oct 16, 2023

Conversation

Nate-Wessel
Copy link
Contributor

Closes #76

@Nate-Wessel
Copy link
Contributor Author

Nate-Wessel commented Oct 6, 2023 •
edited
Loading

A few things left that I'd like to do here:

  • Where there are only one or two, indicate which holidays are potentially in range. E.g. "exclude Canada Day?" Nice to have but not essential
  • Hide the option when it wouldn't have any effect

Maybe these can become separate issues though...
I don't think there is too much danger in merging this in as is.

edit: done! #85

@Nate-Wessel Nate-Wessel marked this pull request as ready for review October 6, 2023 19:54
@Nate-Wessel Nate-Wessel merged commit d8f9a50 into deploy Oct 16, 2023
1 check passed
@Nate-Wessel Nate-Wessel deleted the holidays branch October 16, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
back-end front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create option for holiday inclusion / exclusion
1 participant
@Nate-Wessel