Bump dep version to 0.5.4 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need the fix for submodules golang/dep#2168
natebrennand
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
https://golang.github.io/dep/blog/2018/07/25/announce-v0.5.0.html
NOTE: your whole team will need to update at once to this new release, as it results in changes to the structure of Gopkg.lock that older versions of dep won't know how to work with.
I think this should be OK since we use a separate copy of dep per repo, but FYI
|
Ah great point - totally forgot about that. I'll let #eng know I'm making the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the fix for submodules: golang/dep#2168
I'm having issues importing
https://github.com/jaegertracing/jaeger-client-goI don't see any breaking changes in the release notes