Fix clean of submodules #2168
Fix clean of submodules #2168
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Hey, I can't reproduce this issue, can you describe what you did to test this change? I'm a little confused because you should be able to write the command with spaces in between, after the "foreach" instead of needing to list it all as one command. Maybe we need a "--" ? |
|
I never used to hit this in my projects that have submodules but I hit it now. The only thing that has changed on my end is my git version. I upgraded git via brew a few days ago: My dep version hasn't changed: |
|
Hi, in my case I have: |
|
You could reproduce it directly with git and the repository that I wrote: In summary, if you avoid assembling the git clean options then the options are seen as git submodule options and this break the execution. |
|
OK |
1 similar comment
|
OK |
Previously, the "-x" in
git submodule foreach --recursive git clean -x
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Fixes #2164.
Fixes #2168.
Previously, the "-x" in
git submodule foreach --recursive git clean -x
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Originally submitted as #2164 by Daniele Rodina
<[email protected]>, re-submitted by me to amend the commit and
merge immediately.
Fixes #2164.
Fixes #2168.
Previously, the "-x" in
git submodule foreach --recursive git clean -x
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Originally submitted as #2164 by Daniele Rodina
<[email protected]>, re-submitted by me to amend the commit and
merge immediately.
Fixes #2164.
Fixes #2168.
Previously, the "-x" in
git submodule foreach --recursive git clean -x
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Originally submitted as #2164 by Daniele Rodina
<[email protected]>, re-submitted by me to amend the commit and
merge immediately.
Fixes #2164.
Fixes #2168.
we need the fix for submodules golang/dep#2168
Fix execution with the vendor with submodules.
What does this do / why do we need it?
This fix error: