Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming water from a pond results as consuming a "null" #76425

Closed
MH10295 opened this issue Sep 14, 2024 · 3 comments · Fixed by #76819
Closed

Consuming water from a pond results as consuming a "null" #76425

MH10295 opened this issue Sep 14, 2024 · 3 comments · Fixed by #76819
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@MH10295
Copy link

MH10295 commented Sep 14, 2024

Describe the bug

  1. Consuming water from a source of water results in consuming a null.

Attach save file

Vyartas-trimmed.tar.gz

Steps to reproduce

  1. Find a pond, river, or lake.
  2. "e" to interact with water tile.
  3. Select "consume it".

Expected behavior

Expected water to be consumed.

Screenshots

No response

Versions and configuration

  • OS: Android
    • OS Version: Manufacturer: samsung; Model: SM-G990U2; Release: 14; Incremental: G990U2SQS7FXA2;
  • Game Version: cdda-experimental-2024-09-14-0515 b8b5c5c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Sky Island [skyisland],
    Aftershock [aftershock],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm],
    Mind Over Matter [mindovermatter],
    Xedra Evolved [xedra_evolved],
    DinoMod [DinoMod],
    Megafauna [megafauna],
    Bombastic Perks [bombastic_perks],
    Crazy Cataclysm [crazy_cataclysm],
    Extra Mutated Scenarios [extra_mut_scens],
    Martial Mastery [perk_melee_system],
    Mythical Martial Arts [MMA],
    Bionic Slots [cbm_slots],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Tamable Wildlife [Tamable_Wildlife]
    ]

Additional context

No response

@MH10295 MH10295 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 14, 2024
@GuardianDll
Copy link
Member

GuardianDll commented Sep 14, 2024

obviously the reason is #76366, but i don't understand how i didn't have it while testing it
image
UPD: i can't find where the game assign consume_item in consume_activity_actor :/
Upd upd:
IMG_20240914_164927
717630e specifically, if anyone's interested in tackling it. That introduced the logic to allow using item_locations in that code path. But it either needs extra work to properly handle consuming from terrain and not items or possibly just a revert and a different approach to fix using charges when aborting.

@GuardianDll GuardianDll added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Sep 14, 2024
@BaumgeistOne
Copy link

Is this the same problem as in #76398 ?

@MH10295
Copy link
Author

MH10295 commented Sep 17, 2024

Probably, it seems you can consume fine from containers, it's just consuming from a tile or piece of furniture that doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants