Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supernatural abilities menu, cutoff at the top #76746

Closed
ryeookin opened this issue Sep 30, 2024 · 12 comments · Fixed by #77123
Closed

Supernatural abilities menu, cutoff at the top #76746

ryeookin opened this issue Sep 30, 2024 · 12 comments · Fixed by #77123
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@ryeookin
Copy link

Describe the bug

My game was a few months old and I ended up updating it yesterday. After doing so when I open the "supernatural abilities" menu it shows my spells/abilities but cuts them off at the top.
How can one fix this?

Note: This issue wasn't present pre-update.
Thanks for your time.

Attach save file

Tombstone-trimmed.tar.gz

Steps to reproduce

This happens every time I open my supernatural abilities menu. I've also tried closing/reopening CDDA but the issue still persists with my save.

Expected behavior

It shouldn't cut off the top of that menu.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.4249 (23H2)
  • Game Version: cdda-experimental-2024-09-29-0806 26de5a1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Slowdown Fungal Growth [no_fungal_growth],
    Mythical Martial Arts [MMA],
    Portal Storms Ignore NPCs [personal_portal_storms],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Magiclysm [magiclysm],
    Mind Over Matter [mindovermatter],
    Xedra Evolved [xedra_evolved],
    Bombastic Perks [bombastic_perks],
    Alternative Map Key [alt_map_key],
    Minimod: No Skill Rust [minimod_no_rust],
    Ryans no lieutenant mod [aRyanMod_blacklist_lieutenant]
    ]

Additional context

No response

@ryeookin ryeookin added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 30, 2024
@yamil-90
Copy link

yamil-90 commented Oct 1, 2024

can confirm, been having this problem since i upgraded to the 2024-09-18-0731 version. cant see the name of the spells and some tables are hidden by the window's border
image

@ryeookin
Copy link
Author

ryeookin commented Oct 1, 2024

Interesting.. so you're issue is with the right side of the window that doesn't contain all the writeup for the spell for you, where as my issue is with the left side of the window which cuts off the top (which for me blocks one spell that's just off the top of the screen and also doesn't thus show what list we're in such as 'favorites', 'technomancer', 'magus', etc).

The specifics are different but we're both clearly having issues with formatting of this window and its text.🤔

@yamil-90
Copy link

yamil-90 commented Oct 1, 2024

i too have the same issue with the top of the window not being visible, cant really tell if im in the favorites, druid etc tab. also it seems like the size of the window depends of the amount of spells that are shown when you open it. for example if i dont have any favorite spells when i open the window it will show the "all" tab and the window will try to accommodate all the spell i know so it will be bigger, but will not resize if i change to the other tabs like druid or earthbender or whatever. but if i select a couple of spells as favorites close and reopen the window the favorite tab takes priority so it will be smaller as it only needs to show 2 or 3 spells. but when i cycle to the "all" tab the size of the window doesnt change.
also the spell description when trying to study it gets cut off and i cant see my current level. maybe its hidden somewhere
image

@MorphingE
Copy link
Contributor

Interesting.. so you're issue is with the right side of the window that doesn't contain all the writeup for the spell for you, where as my issue is with the left side of the window which cuts off the top (which for me blocks one spell that's just off the top of the screen and also doesn't thus show what list we're in such as 'favorites', 'technomancer', 'magus', etc).

The specifics are different but we're both clearly having issues with formatting of this window and its text.🤔

I have both issues, to a degree. It was fine until I had enough spells that it started to require scrolling. After that, it pretty much broke (the left side) so that the first 2 spells are out of view at the top. The right hand window is largely fine for me, but some spells don't wordwrap certain extra details. Might be an issue with the spell's description, but I haven't checked yet on that.
Num2

@ryeookin
Copy link
Author

ryeookin commented Oct 2, 2024

@yamil-90 Ah I see, yeah we overlap there too.
@MorphingE
Hmm, so maybe it is breaking because we have more then it can handle in its current iteration? I mean it should be able to handle so many spells, but seemingly isn't.

Also, yeah I am missing some characters on the right as well. Here's my section of 'return critters':
image

@GuardianDll GuardianDll added (S2 - Confirmed) Bug that's been confirmed to exist ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 3, 2024
@db48x
Copy link
Contributor

db48x commented Oct 6, 2024

Let’s try to keep to one bug report per bug report, as it were. The text wrapping and formatting in the spell description is fixed by #76513, so we needn’t include it here. Likewise #75666 covers the missing category display. Note that you can still switch categories with the keyboard shortcuts, it just doesn’t show you which one you’re in.

Cutting off the top of the window is new to me, however, as it is intended to max out at the vertical height of your screen and then scroll if there are more menu entries than will fit. Do you get the same height problem if you use the Debug → Spawning → Spawn an item menu? It lists every possible item in the game, so it’s rather tall.

@ryeookin
Copy link
Author

ryeookin commented Oct 6, 2024

@db48x
I tried that, here's what I'm seeing:
image
Is that normal?

@ryeookin
Copy link
Author

ryeookin commented Oct 6, 2024

Note that is a copy/paste of my full screen. If I hit up from "boiler" it doesn't move to a hidden option above it, it takes me to the bottom of the list.

Anything else you want me to test?

@db48x
Copy link
Contributor

db48x commented Oct 6, 2024

Yes, that’s normal.

@ryeookin
Copy link
Author

ryeookin commented Oct 8, 2024

Alright, after you existing bug reports get merged I'll update and test it again. Here's hoping they fix this issue too.

db48x added a commit to db48x/Cataclysm-DDA that referenced this issue Oct 18, 2024
Allows the user to select a category using the mouse, in addition to
the existing key bindings.

Also tweaks how the size of the uilist is computed a bit, to keep the
calculated_menu_size correct even when the caller specifies desired_bounds.

Fixes CleverRaven#75666
Fixes CleverRaven#76746
@ryeookin
Copy link
Author

I just tested it myself after updating and I wanted to confirm this fixed it on my end as well. Thanks for the fix! :D

@db48x
Copy link
Contributor

db48x commented Oct 20, 2024

You’re welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants