add a tab bar to the uilist showing categories, if there are any #77123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to select a category using the mouse, in addition to the existing key bindings. Also tweaks how the size of the uilist is computed a bit, to keep the calculated_menu_size correct even when the caller specifies desired_bounds. Fixes CleverRaven#75666 Fixes CleverRaven#76746
db48x
force-pushed
the
uilist-categories
branch
from
8aeb124
to
c096cc9
Compare
github-actions
bot
added
Info / User Interface
github-actions
bot
added
json-styled
This describes the purpose of the variable rather than how it was obtained.
github-actions
bot
added
BasicBuildPassed
|
As mentioned, this is likely the culprit of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "uilist menus that have categories now include a tabbar to allow the user to select a category"
Purpose of change
Describe the solution
Allows the user to select a category using the mouse, in addition to the existing key bindings.
Also tweaks how the size of the uilist is computed a bit, to keep the calculated_menu_size correct even when the caller specifies desired_bounds.
Testing
Start a game with Magiclysm, use the debug menu to edit your character, add some spells. Then check the spellcasting menu to see if it looks right. Then go back and add every spell (default key binding is
t). Check the spellcasting menu again to make sure it still looks right.Additional context