Do not move into monsters that we cannot displace #47717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Do not move into monsters that we cannot displace"
Purpose of change
When you are on a fence and moves into a friendly monster that cannot move onto the fence, the player moves into the monster anyway and occupies the same space as the monster.
Describe the solution
Return the original player position from
game::place_player
if the monster cannot be moved, so both the monster and the player are not moved.To get past the string freeze, an existing string is used for the message when the monster fails to move.
Testing
Climb onto a fence and tried to move into a nearby monster. The player did not move and a message was shown.