Don't unnecessarily copy items in a tight loop in get_uncraft_components #76574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
RenechCDDA
reviewed
Sep 20, 2024
akrieger
force-pushed
the
no_duping_allowed
branch
from
6566ace
to
7c286c7
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance "Fix lag examining large stacks of crafted items"
Purpose of change
Fixes #76514. Fixes #73502. A performance problem was reported. The performance problem smasher showed up for duty.
Describe the solution
Inside
get_uncraft_components, take the inner loopitemby ref for the lambda tostd::find_if.Describe alternatives you've considered
Testing
examine the repro save freezer full of food three times before/after.Additional context