Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Don't unnecessarily copy items in a tight loop in get_uncraft_components" #76603

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Backport "Don't unnecessarily copy items in a tight loop in get_uncraft_components" #76603

merged 1 commit into from
Sep 30, 2024

Conversation

akrieger
Copy link
Member

Summary

Performance "Backport Don't unnecessarily copy items in a tight loop in get_uncraft_components"

Purpose of change

Backports #76574

Describe the solution

One character performance fixes are free to backport.

Describe alternatives you've considered

Giving people more reasons to play experimental when it is noticeably slow to root through thousands of hot dogs for the one you crafted 4 hours ago but not 4 days ago.

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Performance Performance boosting code (CPU, memory, etc.) Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 29, 2024
@Maleclypse Maleclypse merged commit 71dcd14 into CleverRaven:0.H-branch Sep 30, 2024
18 of 23 checks passed
@akrieger akrieger deleted the backport_no_item_duping branch October 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Performance Performance boosting code (CPU, memory, etc.) <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrieger @Maleclypse