Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Kord mission #76626

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

cknight828
Copy link
Contributor

@cknight828 cknight828 commented Sep 23, 2024

Summary

None

Purpose of change

Fix #76316

It is checked that the player has already accepted the kord mission in the Cody's first topic, but not in the topic about the location. So the mission can be accepted infinitely.
If the player give the broken kord to Jay before complete Cody's mission, they cannot it complete anymore.
The player receives repaired kord when the debug software mission is completed, but they can accept this mission without giving the broken kord to Jay.

Describe the solution

Add that check to the topic about the location.
Ensure the player give the broken kord to Jay after the mission is completed.

Describe alternatives you've considered

Testing

Go to Cody and accept the kord mission. It is not offered anymore once accpeted.
Jay does not receive the broken kord before it is completed, and after it he always receives.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 23, 2024
@cknight828 cknight828 marked this pull request as draft September 23, 2024 08:42
@github-actions github-actions bot added Missions Quests and missions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 23, 2024
@cknight828 cknight828 changed the title Fix Cody offers the Kord mission more than once Fix the Kord mission Sep 23, 2024
@cknight828 cknight828 marked this pull request as ready for review September 23, 2024 10:15
@Maleclypse Maleclypse merged commit 8c7611c into CleverRaven:master Sep 24, 2024
33 of 41 checks passed
@cknight828 cknight828 deleted the fix-cody-mission branch September 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody doesn't recognize her quest's completion
2 participants