Build fix #267
Merged
Build fix #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only target_link_libraries() for imported interface target
filimonov
requested changes
Feb 24, 2020
There was a problem hiding this comment.
- Readme needs to be updated.
- fix Travis to use latest cmake
https://github.com/SebastianSchlag/kahypar/blob/master/.travis.yml#L62
https://riptutorial.com/cmake/example/4723/configure-travis-ci-with-newest-cmake
etc.
What exactly do you mean here? |
I've missed the change of required version of cmake in readme. Optionally - you may add a note like: Most of Linux distibutions has old version of cmake. Please install it from url ... What happened with mac builds? It looks like it can't find iodbc? |
filimonov
approved these changes
Feb 24, 2020
* master: Add convert()'s that accept moving-into source values Clarify/fix temporaries handling Comments from @Enmk Add note about deifference in timezone handling between formats Set OPENSSL_ROOT_DIR explicitly Try versionned openssl package name Working around wierd behavior of brew Add "URL query string" section Update brew before installing packages Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263.
Closes #12.