Merge pull request #669 from HeEAaD/en_development_region

Use modern localization identifier 'en' for the development region
CocoaPods · Apr 16, 2019 · 45e59e6 · 45e59e6
2 parents d7d1b63 + 4e32a04
commit 45e59e6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,9 @@
 * Normalize xcconfig path when generating includes.  
   [bclymer](https://github.com/bclymer)
 
+* Use modern localization identifier 'en' for the development region.
+  [Steffen Matthischke](https://github.com/heeaad)
+
 ## 1.8.1 (2019-02-19)
 
 ##### Enhancements

diff --git a/lib/xcodeproj/project/object/root_object.rb b/lib/xcodeproj/project/object/root_object.rb
@@ -34,7 +34,7 @@ class PBXProject < AbstractObject
 
         # @return [String] the development region of the project.
         #
-        attribute :development_region, String, 'English'
+        attribute :development_region, String, 'en'
 
         # @return [String] whether the project has scanned for encodings.
         #

diff --git a/spec/project/object/root_object_spec.rb b/spec/project/object/root_object_spec.rb
@@ -24,7 +24,7 @@ module ProjectSpecs
     end
 
     it 'returns the development region' do
-      @root_object.development_region.should == 'English'
+      @root_object.development_region.should == 'en'
     end
 
     it 'returns whether has scanned for encodings' do