Sk ja create edit programs #76

ja0911 · 2022-10-16T22:26:45Z

ℹ️ Issue

Closes #59

📝 Description

Implemented UI for Admins to create and edit events in the Programs page

✔️ Verification

Tested functionality and UI on local server

🏕️ (Optional) Future Work / Notes

Form values are yet to be stored in variables

thejamielin

Great progress so far! will make more reviews tomorrow

lib/components/header/index.tsx

lib/components/edit-program-modal/index.tsx

adriannaliu

looking great so far guys! jamie made some good points, but other than that lgtm!

adriannaliu

thanks for addressing all the changes! mind taking a look at the failing check?

yanDavid21 · 2022-10-24T05:51:11Z

nit: non-functional changes should be kept separate from functional changes (ie. .github and prettier, white space changes)

yanDavid21

Looks good! submitted a couple bits of feedback, lmk if you agree

lib/components/create-program-modal/index.tsx

lib/components/edit-program-modal/index.tsx

lib/components/header/index.tsx

yanDavid21 · 2022-10-24T06:00:16Z

lib/components/header/index.tsx

+      <Flex flexDir={'row'} justifyContent="space-between" mb={'3px'}>
+        <Heading>{header}</Heading>
+        {hasButton ? (
+          <Button


Perhaps a separate functional component would be helpful here so you can name this button, because right now I'd have to dig where this is called to figure out the context/meaning of the button

+1 to this!

lib/components/pop-up/index.tsx

lib/components/programs-list/index.tsx

saahilkumar · 2022-10-26T17:14:40Z

Will EditProgramModal and CreateProgramModal both have Pop and ProgramModal components? If so, I think abstraction would still be helpful if you anticipate a change to one would mean a change to another

I think they're as abstracted as they should be rn, the only similarity between the two is that they use the same form which we abstracted into ProgramForm. Wdym by "a change to one would mean a change to another"?

thejamielin

still reading through this! lg so far

.github/ISSUE_TEMPLATE/ticket-story.md

.github/pull_request_template.md

.github/workflows/ci.yml

.prettierrc.json

cypress/integration/TC01_about_us.spec.js

global.d.ts

lib/components/program-form/index.tsx

lib/components/programs-list/index.tsx

lib/components/edit-program-modal/index.tsx

… sk-ja-create-edit-programs

thejamielin

found some last couple things! i think we can get this merged as soon as we resolve these comments

thejamielin · 2022-11-02T23:41:22Z

lib/components/header/index.tsx

+      <Flex flexDir={'row'} justifyContent="space-between" mb={'3px'}>
+        <Heading>{header}</Heading>
+        {hasButton ? (
+          <Button


+1 to this!

lib/components/pop-up/index.tsx

pages/programs/index.tsx

thejamielin

Omg fantastic work @saahilkumar and @ja0911! Please respond to the comments and you can decide whether or not you want to merge what we have now, or update the formatting

thejamielin · 2022-11-04T16:45:25Z

pages/programs/index.tsx

-      </Flex>
-    </Container>
+    <>
+      <CreateProgramModal modalManagement={createProgramModalManagement} />


Did we want to adjust the header so our implementation matches the Figma file?

Figma:

Current Implementation:

I'm ok with changing it, don't really have a preference. It's just like that cuz the header was recently changed to not have the line go all the way to the end

i think Al fixed the october events so that the line extends all the way to the end bc of Jamie's PR comment about that, so can we stay consistent :3

thejamielin · 2022-11-04T16:50:46Z

lib/components/programs-list/index.tsx

-          _hover={{ textDecoration: 'none' }}
-          _focus={{ outline: 'none' }}>
+    <>
+      <EditProgramModal modalManagement={editProgramModalManagement} />


Small thing but I want to know your thoughts: In the Figma designs, we don't have a version with both buttons yet since the Admin version technically can't see the button

Figma Comparison

![image](https://user-images.githubusercontent.com/71473137/200030680-d4fe71c8-fae8-45e2-adc7-c00e9a94b669.png)

Seems like it would make sense to keep the Register here button on the Admin version
Should we distance these buttons or add an "edit" icon to make them look more distinct?

adriannaliu

approving this so you guys have the option of merging, but check out this slack thread regarding using icons

saahilkumar · 2022-11-06T23:37:15Z

I can add the icons in tomorrow probably

adriannaliu

amazing guys

thejamielin

this is literally fire! great job @ja0911 and @saahilkumar

saahilkumar added 2 commits October 9, 2022 16:44

Add edit programs button and modal

ceebfad

Add create programs button and modal

e11ac68

ja0911 requested review from thejamielin and adriannaliu as code owners October 16, 2022 22:26

ja0911 assigned ja0911 and saahilkumar Oct 16, 2022

thejamielin requested changes Oct 18, 2022

View reviewed changes

lib/components/header/index.tsx Outdated Show resolved Hide resolved

lib/components/header/index.tsx Outdated Show resolved Hide resolved

lib/components/edit-program-modal/index.tsx Show resolved Hide resolved

adriannaliu reviewed Oct 19, 2022

View reviewed changes

saahilkumar and others added 2 commits October 19, 2022 18:49

Make Create Event button responsive

cefc573

Merge branch 'master' into sk-ja-create-edit-programs

143f054

adriannaliu self-requested a review October 23, 2022 19:42

adriannaliu requested changes Oct 23, 2022

View reviewed changes

fix failing check

0ea0059

adriannaliu requested a review from thejamielin October 23, 2022 22:58

ja0911 added 2 commits October 23, 2022 18:58

ran prettier

24618cc

small fix

21e2a55

yanDavid21 reviewed Oct 24, 2022

View reviewed changes

ja0911 added 3 commits October 30, 2022 18:40

address david's comments

ee097ae

formatting fixes

dc4ce45

expand modal sizes enum

11c029d

thejamielin reviewed Oct 31, 2022

View reviewed changes

removed unnecessary props

7d39636

adriannaliu requested a review from lucass0717 October 31, 2022 23:23

lucass0717 reviewed Nov 1, 2022

View reviewed changes

lib/components/programs-list/index.tsx Outdated Show resolved Hide resolved

lucass0717 reviewed Nov 1, 2022

View reviewed changes

lib/components/edit-program-modal/index.tsx Show resolved Hide resolved

ja0911 and others added 2 commits November 1, 2022 15:00

remove files out of scope

13e7902

Merge branch 'master' of https://github.com/Code-4-Community/vsc into…

7120327

… sk-ja-create-edit-programs

thejamielin requested changes Nov 2, 2022

View reviewed changes

Minor tweaks to create/edit buttons

bc727a8

thejamielin previously approved these changes Nov 4, 2022

View reviewed changes

adriannaliu previously approved these changes Nov 6, 2022

View reviewed changes

fix merge conflicts in programs to also include the button to create

40eb8af

thejamielin dismissed stale reviews from adriannaliu and themself via 40eb8af November 6, 2022 19:52

remove unnecessary files from idea

0f7f9fe

saahilkumar and others added 2 commits November 7, 2022 15:39

Replace edit button text with an icon

5f3485e

prettier fix

b0ad000

adriannaliu approved these changes Nov 8, 2022

View reviewed changes

thejamielin approved these changes Nov 15, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sk ja create edit programs #76

Sk ja create edit programs #76

ja0911 commented Oct 16, 2022

thejamielin left a comment

adriannaliu left a comment

adriannaliu left a comment

yanDavid21 commented Oct 24, 2022 •

edited

Loading

yanDavid21 left a comment

yanDavid21 Oct 24, 2022

thejamielin Nov 2, 2022

saahilkumar commented Oct 26, 2022

thejamielin left a comment

thejamielin left a comment

thejamielin Nov 2, 2022

thejamielin left a comment

thejamielin Nov 4, 2022

saahilkumar Nov 6, 2022

adriannaliu Nov 7, 2022

thejamielin Nov 4, 2022

adriannaliu left a comment

saahilkumar commented Nov 6, 2022

adriannaliu left a comment

thejamielin left a comment

Sk ja create edit programs #76

Are you sure you want to change the base?

Sk ja create edit programs #76

Conversation

ja0911 commented Oct 16, 2022

ℹ️ Issue

📝 Description

✔️ Verification

🏕️ (Optional) Future Work / Notes

thejamielin left a comment

Choose a reason for hiding this comment

adriannaliu left a comment

Choose a reason for hiding this comment

adriannaliu left a comment

Choose a reason for hiding this comment

yanDavid21 commented Oct 24, 2022 • edited Loading

yanDavid21 left a comment

Choose a reason for hiding this comment

yanDavid21 Oct 24, 2022

Choose a reason for hiding this comment

thejamielin Nov 2, 2022

Choose a reason for hiding this comment

saahilkumar commented Oct 26, 2022

thejamielin left a comment

Choose a reason for hiding this comment

thejamielin left a comment

Choose a reason for hiding this comment

thejamielin Nov 2, 2022

Choose a reason for hiding this comment

thejamielin left a comment

Choose a reason for hiding this comment

thejamielin Nov 4, 2022

Choose a reason for hiding this comment

saahilkumar Nov 6, 2022

Choose a reason for hiding this comment

adriannaliu Nov 7, 2022

Choose a reason for hiding this comment

thejamielin Nov 4, 2022

Choose a reason for hiding this comment

adriannaliu left a comment

Choose a reason for hiding this comment

saahilkumar commented Nov 6, 2022

adriannaliu left a comment

Choose a reason for hiding this comment

thejamielin left a comment

Choose a reason for hiding this comment

yanDavid21 commented Oct 24, 2022 •

edited

Loading