-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Composer executable #32
Conversation
…e Composer version between all the environments and developers workstations 🔝
…e previous version didn't match with the `composer.json` one.
…ts.0". Expected scalar, but got object."
…n: The service "jms_serializer.stopwatch_subscriber" has a dependency on a non-existent service "debug.stopwatch"". More info: schmittjoh/JMSSerializerBundle#624
…imilarComparator#assertEquals` not being compatible with `SebastianBergmann\Comparator\ObjectComparator#assertEquals`
…t` over `null`s: "count(): Parameter must be an array or an object that implements Countable"
* Make the `UnitTestCase` class extend from `MockeryTestCase` in order to close and check Mockery assertions. This is the recommended way since Mockery 1.0: http://docs.mockery.io/en/latest/reference/phpunit_integration.html
Instead of commiting this (versioning code that isn't ours), we could have something to download the binary if it's not presend inside a We could download specific versions using https://getcomposer.org/download/1.6.3/composer.phar (we could create a |
I agree with you. What you're proposing is a better solution than including the Composer binary. However, I would suggest to add it as a feature request opening a new issue, and merging this solution in the meantime. Why: This way, despite not being the best solution, we could avoid generating different |
Move `CourseIdStub` to test namespace
Update composer dependencies and stabilize build
I'll merge this PR since it is needed in order to integrate other changes such as #33 & #34. Those are changes requested by some CodelyTV Pro courses users. Please, raise your hand in case you don't agree with the #32 (comment) @rgomezcasas |
Include
composer.phar
in order to be sure of executing the very same Composer version between all the environments and developers workstations 🔝