Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer dependencies and stabilize build #33

Merged
merged 13 commits into from
Mar 25, 2018

Conversation

JavierCane
Copy link
Member

  • Run composer update in order to update the composer.lock since the previous version didn't match with the composer.json one.
  • Fix for deprecated YAML usages of parameters without being quoted
  • Fix for "Invalid type for path "monolog.handlers.main.channels.elements.0". Expected scalar, but got object."
  • Update JMS Serializer bundle in order to fix "ServiceNotFoundException: The service "jms_serializer.stopwatch_subscriber" has a dependency on a non-existent service "debug.stopwatch"". More info: Move symfony/stopwatch to require instead of require-dev schmittjoh/JMSSerializerBundle#624
  • Fix for DateTimeSimilarComparator#assertEquals and DateTimeStringSimilarComparator#assertEquals not being compatible with SebastianBergmann\Comparator\ObjectComparator#assertEquals
  • Fix failing vendor/bin/behat -p applications test due to invalid YAML
  • Update Mockery in order to fix error due to PHP 7.2 deprecating count over nulls: "count(): Parameter must be an array or an object that implements Countable"
  • Update PhpUnit to 6.5 in order to be compatible with Mockery 1.0
  • Fix PhpUnit assertions usage from ApiResponseContext

…e previous version didn't match with the `composer.json` one.
…n: The service "jms_serializer.stopwatch_subscriber" has a dependency on a non-existent service "debug.stopwatch"". More info: schmittjoh/JMSSerializerBundle#624
…imilarComparator#assertEquals` not being compatible with `SebastianBergmann\Comparator\ObjectComparator#assertEquals`
…t` over `null`s: "count(): Parameter must be an array or an object that implements Countable"
* Make the `UnitTestCase` class extend from `MockeryTestCase` in order to close and check Mockery assertions. This is the recommended way since Mockery 1.0: http://docs.mockery.io/en/latest/reference/phpunit_integration.html
@JavierCane
Copy link
Member Author

With this PR we return to the greenzone of successful CircleCI builds 🙂

@JavierCane JavierCane merged commit e82ae11 into include-composer Mar 25, 2018
@JavierCane JavierCane deleted the fix-composer-dependencies branch March 25, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants