Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss augmented inference using SparseNetworks #445

Merged
merged 38 commits into from
Dec 5, 2016
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
be2f7b4
-added the Badge Example
kordjamshidi Nov 4, 2016
b6acc34
-added the Badge Example Reader
kordjamshidi Nov 4, 2016
4d4d979
-added Badge example with loss augmented inference
kordjamshidi Nov 4, 2016
75a071e
-format
kordjamshidi Nov 4, 2016
e1a106e
-fixed the test
kordjamshidi Nov 4, 2016
9f40b24
-fixed the tests due to the fix in initialization
kordjamshidi Nov 4, 2016
4a578c4
-test size of weights
kordjamshidi Nov 4, 2016
cd57748
learning configuration
kordjamshidi Nov 5, 2016
55a808c
Merge remote-tracking branch 'upstream/master' into loss-augmented
kordjamshidi Nov 5, 2016
09f4aaa
-added documentation
kordjamshidi Nov 5, 2016
bca4262
-modified and documented the badge example
kordjamshidi Nov 5, 2016
ea0198b
-assert the type
kordjamshidi Nov 6, 2016
ed706a3
-minor
kordjamshidi Nov 6, 2016
da9b768
-added pipeline example with Badge
kordjamshidi Nov 10, 2016
b15189e
-improved documentation
kordjamshidi Nov 11, 2016
0776234
-improved documentation
kordjamshidi Nov 11, 2016
053f965
-relative path works for java folder?!
kordjamshidi Nov 14, 2016
77b0a13
-relative path works for java folder?!
kordjamshidi Nov 14, 2016
73c67a0
-improved documentation
kordjamshidi Nov 14, 2016
4ad5840
format
kordjamshidi Nov 14, 2016
c104fff
SRL join-training
kordjamshidi Nov 16, 2016
e668bdd
Fixed the RunningApps name in the documentation
kordjamshidi Nov 16, 2016
dce32e9
temporarily removed joinnodes populate for SRL experiments
kordjamshidi Nov 16, 2016
8059746
-train mode
kordjamshidi Nov 16, 2016
f91e18d
-use Gurobi
kordjamshidi Nov 16, 2016
e006bb9
-remove logger messages
kordjamshidi Nov 16, 2016
ff5c9f3
-jointTrain setting
kordjamshidi Nov 18, 2016
754d694
format
kordjamshidi Nov 18, 2016
92de796
-fixed the test units path for SRL
kordjamshidi Nov 18, 2016
9cf1f25
-format
kordjamshidi Nov 18, 2016
5186251
-replaced configuration parameters
kordjamshidi Nov 18, 2016
e1ea9a4
-replaced configuration parameters
kordjamshidi Nov 18, 2016
aba475b
-added results of join training (IBT) with SRL ArgTypeClassifier
kordjamshidi Dec 3, 2016
a65cd4e
-brought the logger messages back
kordjamshidi Dec 3, 2016
bcdba7e
-changed back the solver for tests
kordjamshidi Dec 3, 2016
dab55f1
-changed back the commented out join node population
kordjamshidi Dec 3, 2016
4d8f361
-fixed typos in blocking
kordjamshidi Dec 5, 2016
b0baf94
-fixed typos in blocking
kordjamshidi Dec 5, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Visit each link for its content
5. [Data modeling and feature extraction](saul-core/doc/DATAMODELING.md)
6. [Learners and constraints](saul-core/doc/SAULLANGUAGE.md)
7. [Model configurations](saul-core/doc/MODELS.md)
8. [Saul library](saul-core/doc/LBJLIBRARY.md)

The api docs are included [here](http://cogcomp.cs.illinois.edu/software/doc/saul/).

Expand Down
121 changes: 116 additions & 5 deletions saul-core/doc/MODELS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,117 @@
* Designing flexible learning models including various configurations such as:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a page title here?
For example

# Learning Paradigms

* Local models i.e. single classifiers. (Learning only models (LO)).
* Constrained conditional models (CCM)[1] for training independent classifiers and using them jointly for global decision making in prediction time. (Learning+Inference (L+I)).
* Global models for joint training and joint inference (Inference-Based-Training (IBT)).
* Pipeline models for complex problems where the output of each layer is used as the input of the next layer.

#Learning Paradigms

/*Documented by Parisa Kordjamshidi*/

Saul facilitates the flexible design of complex learning models with various configurations.
By complex models we mean the models that aim at prediction of more than one output variable where these outputs might have relationships to each other.
Such models can be designed using the following paradigms,

* [Local models](#local) trains single classifiers (Learning only models (LO)) each of which learns and predicts a single variable in the output independently.
* [Constrained conditional models (CCM)](#L+I) for training independent classifiers and using them jointly for global decision making in prediction time. (Learning+Inference (L+I)).
* [Global models](#IBT) for joint training and joint inference (Inference-Based-Training (IBT)).
* [Pipeline models](#pipeline) for complex problems where the output of each model is used as the input of the next model (these models are different layers in a pipeline).

The above mentioned paradigms can be tested using this simple badge classifier example, [here](saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/Badge/BagesApp.scala).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop what? the link to the example? why? isn't it useful?


<a name="local">
##Local models
These models are a set of single classifiers. Each classifier is defined with the `Learnable` construct and is trained and makes prediction independent from other classifiers.
The `Learnable` construct requires specifying a single output variable, that is, a label which is itself a property in the data model, and the features which is also a
comma separated list of properties.

```scala
object ClassifierName extends Learnable (node) {
def label = property1
def feature = using(property2,property3,...)
//a comma separated list of properties
}
```

For the details about the `Learnable` construct see [here](SAULLANGUAGE.md).

<a name="L+I">
##Learning+Inference models
These models are useful for when we need to consider the global relations between the outputs of a bunch of classifiers during the
prediction time. Each classifier is defined with the same `Learnable` construct as a local model. In addition to the Learnable definitions, the programmer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Learnable?

has the possibility to define a number of logical constraints between the output of the Learnables (classifiers).
Having the constraint definitions in place (see [here](SAULLANGUAGE.md) for syntax details), the programmer is able to define
new constrained classifiers that use the Learnables and constraints.

```scala
object ConstrainedClassifierName extends ConstrainedClassifier[local_node_type,global_node_type](LocalClassifier)
{
def subjectTo = constraintExpression
// Logical constraint expression comes here, it defines the relations between the
// LocalClassifier and other Learnables defined before
}
```
When we use the above `ConstrainedClassifierName` to call test or make predictions, the `LocalClassifier` is used
but the predictions are made in way that `constraintExpression` is hold. There is no limitation for the type of local classifiers.
They can be SVMs, decision trees or any other learning models available in Saul, [here](https://github.com/IllinoisCogComp/lbjava/blob/master/lbjava/doc/ALGORITHMS.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relative url?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part of the address should be removed?

and [here](https://github.com/IllinoisCogComp/saul/blob/master/saul-core/src/main/java/edu/illinois/cs/cogcomp/saul/learn/SaulWekaWrapper.md).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relative url?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part of the address should be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these links relative (i.e. drop https://github.com/...)

<a name="IBT">
##Inference-based Learning
For the inference based models the basic definitions are exactly similar to the L+I models. In other words, the programmer
just needs to define the `Learnables` and `ConstrainedClassifiers`. However, to train the ConstrainedClassifiers jointly, instead of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ConstrainedClassifiers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ConstrainedClassifiers?

training local classifiers independently, there are a couple of joint training functions that can be called.
These functions receive the list of constrained classifiers as input and train their parameters jointly. In contrast to
L+I models here the local classifiers can be defined as `SparsePerceptron`s or `SparseNetworkLearner`s only. This is because the
joint training should have its own strategy for the wight updates of the involved variables (those variables come down to be the outputs of the local classifiers here).
For the two cases the programmer can use

```scala
JointTrainSparseNetwork.train(param1,param2,...) /* a list of parameters go here*/
JointTrainSparsePerceptron.train(param1,param2,...) /*a list of parameters here*/
```

For example,

```scala JointTrainSparseNetwork.train(badge, cls, 5, init = true, lossAugmented = true)```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style doesn't render correctly. You probably need to move the code into new lines.


The list of parameters are the following:

- param1: The name of a global node in the data model that itself or the connected nodes to it are used by the involved `Learnable`s.

- param2: The collection of ```ConstainedClassifier```s

- param3: The number of iterations over the training data.

- param4: If the local classifiers should be cleaned from the possibly pre-trained values and initialized by zero weights, this parameter should be true.

- param5: If the approach uses the loss augmented objective for making inference, see below for description.

###Basic approach

The basic approach for training the models jointly is to do a global prediction at each step of the training and if the
predictions are wrong update the weights of the related variables.

###Loss augmented

The loss-augmented approach adds the loss of the prediction explicitly to the objective of the training and finds the most violated output per each training example;
it updates the weights of the model according to the errors made in the prediction of the most violated output.
This approach minimizes a convex upper bound of the loss function and has been used in structured SVMs and Structured Perceptrons.
However, considering an arbitrary loss in the objective will make complexities in the optimization, therefore in the implemented version, here, we assume the loss is decomposed similar to
feature function. That is, the loss is a hamming loss defined per classifier. The loss of the whole structured output is computed by the weighted sum of
the loss of its components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example for "The loss of the whole structured output is computed by the weighted sum of the loss of its components."? Like an example "structure" and its prediction and how the weighted loss is calculated (and later used during training).

In Saul, the programmer can indicate if he/she needs to consider this global hamming loss in the objective or not. And this can be done by passing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole paragraph is very ambiguous. Could you add more details, examples, or anything to make this more clear?
If we have an example usage for loss-augmented inference we can point to that too.

the above mentioned `param5` as true in the `JointTrainingSparseNetwork` algorithm.
An example of this usage can be seen [here](saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/Badge/BagesApp.scala) at line #64.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "#L64" at the end of the link and drop "at line #64"?


<a name="pipeline">
##Pipelines
Building pipelines is naturally granted in Saul. The programmer can simply define properties that are the predictions of
the classifiers and use those outputs as the input of other classifiers by mentioning them in the list of the properties in the below construct when defining the
pipeline classifiers,

```scala
def feature = using(/*list of properties including the prediction of other classifiers.*/)
```
.
See [here](saul-examples/src/main/scala/edu/illinois/cs/cogcomp/saulexamples/Badge/BadgeClassifiers.scala), at line #43, for an example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the line number to the link by adding #L43 at the end.



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we include an imaginary example (like the imaginary scenario above for constrained classifier) explaining how things work. The one I mentioned is not good?

object ClassifierLayer1 extends Learnable (node) {
   def label = labelProperty1
   def feature = using(property2, property3,...) 
 }

object ClassifierLayer2 extends Learnable (node) {
   def label = labelProperty2
   def feature = using(classifier1Labels, ,...) // using the prediction of the classifier in the previous layer 
 }

// defined in data-model object 
val classifier1Labels = new Property(node){  x: Type => ClassifierLayer1(x)  }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought a link to the actual working example, which is similar to this one would be enough. I can add this too to the documentation if you really like it.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if we add a very simple example. For example sth like this:

object ClassifierLayer1 extends Learnable (node) {
   def label = labelProperty1
   def feature = using(property2, property3,...) 
 }

object ClassifierLayer2 extends Learnable (node) {
   def label = labelProperty2
   def feature = using(classifier1Labels, ,...) // using the prediction of the classifier in the previous layer 
 }

// defined in data-model 
val classifier1Labels = new Property(node){  x: Type => ClassifierLayer1(x)  }


Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ package edu.illinois.cs.cogcomp.saul.classifier
import edu.illinois.cs.cogcomp.lbjava.learn.{ LinearThresholdUnit, SparseNetworkLearner }
import edu.illinois.cs.cogcomp.saul.datamodel.node.Node
import org.slf4j.{ Logger, LoggerFactory }

import Predef._
import scala.reflect.ClassTag

/** Created by Parisa on 5/22/15.
Expand All @@ -18,16 +18,16 @@ object JointTrainSparseNetwork {

val logger: Logger = LoggerFactory.getLogger(this.getClass)
var difference = 0
def apply[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], init: Boolean)(implicit headTag: ClassTag[HEAD]) = {
train[HEAD](node, cls, 1, init)
def apply[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], init: Boolean, lossAugmented: Boolean)(implicit headTag: ClassTag[HEAD]) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a doc to this function and explain what it does as well as the parameters?

Copy link
Member

@danyaljj danyaljj Nov 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually here what I meant was documentation for the function.
Like:

/** 
* This function does blah blah ... 
* @param node .... 
* @param cls ... 
* .... 
* @param lossAugmented ....
*/

train[HEAD](node, cls, 1, init, lossAugmented)
}

def apply[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], it: Int, init: Boolean)(implicit headTag: ClassTag[HEAD]) = {
train[HEAD](node, cls, it, init)
def apply[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], it: Int, init: Boolean, lossAugmented: Boolean = false)(implicit headTag: ClassTag[HEAD]) = {
train[HEAD](node, cls, it, init, lossAugmented)
}

@scala.annotation.tailrec
def train[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], it: Int, init: Boolean)(implicit headTag: ClassTag[HEAD]): Unit = {
def train[HEAD <: AnyRef](node: Node[HEAD], cls: List[ConstrainedClassifier[_, HEAD]], it: Int, init: Boolean, lossAugmented: Boolean = false)(implicit headTag: ClassTag[HEAD]): Unit = {
// forall members in collection of the head (dm.t) do
logger.info("Training iteration: " + it)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an assertion here to check that the base classifiers are of the type SparseNetworkLearner. Also you can add that to the function documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I already had a line about it in the new documentation.

if (init) ClassifierUtils.InitializeClassifiers(node, cls: _*)
Expand All @@ -43,19 +43,25 @@ object JointTrainSparseNetwork {
if (idx % 5000 == 0)
logger.info(s"Training: $idx examples inferred.")

cls.foreach {
case classifier: ConstrainedClassifier[_, HEAD] =>
val typedClassifier = classifier.asInstanceOf[ConstrainedClassifier[_, HEAD]]
val oracle = typedClassifier.onClassifier.getLabeler
if (lossAugmented)
cls.foreach { cls_i =>
cls_i.onClassifier.classifier.setLossFlag()
cls_i.onClassifier.classifier.setCandidates(cls_i.getCandidates(h).size * cls.size)
}

typedClassifier.getCandidates(h) foreach {
cls.foreach {
currentClassifier: ConstrainedClassifier[_, HEAD] =>
assert(currentClassifier.onClassifier.classifier.getClass.getName.contains("SparseNetworkLearner"), "The classifier should be of type SparseNetworkLearner!")
val oracle = currentClassifier.onClassifier.getLabeler
val baseClassifier = currentClassifier.onClassifier.classifier.asInstanceOf[SparseNetworkLearner]
currentClassifier.getCandidates(h) foreach {
candidate =>
{
def trainOnce() = {
val result = typedClassifier.classifier.discreteValue(candidate)

val result = currentClassifier.classifier.discreteValue(candidate)
val trueLabel = oracle.discreteValue(candidate)
val ilearner = typedClassifier.onClassifier.classifier.asInstanceOf[SparseNetworkLearner]
val lLexicon = typedClassifier.onClassifier.getLabelLexicon
val lLexicon = currentClassifier.onClassifier.getLabelLexicon
var LTU_actual: Int = 0
var LTU_predicted: Int = 0
for (i <- 0 until lLexicon.size()) {
Expand All @@ -69,26 +75,25 @@ object JointTrainSparseNetwork {
// and the LTU of the predicted class should be demoted.
if (!result.equals(trueLabel)) //equals("true") && trueLabel.equals("false") )
{
val a = typedClassifier.onClassifier.getExampleArray(candidate)
val a = currentClassifier.onClassifier.getExampleArray(candidate)
val a0 = a(0).asInstanceOf[Array[Int]] //exampleFeatures
val a1 = a(1).asInstanceOf[Array[Double]] // exampleValues
val exampleLabels = a(2).asInstanceOf[Array[Int]]
val label = exampleLabels(0)
var N = ilearner.getNetwork.size
val N = baseClassifier.getNetwork.size

if (label >= N || ilearner.getNetwork.get(label) == null) {
val conjugateLabels = ilearner.isUsingConjunctiveLabels | ilearner.getLabelLexicon.lookupKey(label).isConjunctive
ilearner.setConjunctiveLabels(conjugateLabels)
if (label >= N || baseClassifier.getNetwork.get(label) == null) {
val conjugateLabels = baseClassifier.isUsingConjunctiveLabels | baseClassifier.getLabelLexicon.lookupKey(label).isConjunctive
baseClassifier.setConjunctiveLabels(conjugateLabels)

val ltu: LinearThresholdUnit = ilearner.getBaseLTU
ltu.initialize(ilearner.getNumExamples, ilearner.getNumFeatures)
ilearner.getNetwork.set(label, ltu)
N = label + 1
val ltu: LinearThresholdUnit = baseClassifier.getBaseLTU.clone().asInstanceOf[LinearThresholdUnit]
ltu.initialize(baseClassifier.getNumExamples, baseClassifier.getNumFeatures)
baseClassifier.getNetwork.set(label, ltu)
}

// test push
val ltu_actual = ilearner.getLTU(LTU_actual).asInstanceOf[LinearThresholdUnit]
val ltu_predicted = ilearner.getLTU(LTU_predicted).asInstanceOf[LinearThresholdUnit]
val ltu_actual = baseClassifier.getLTU(LTU_actual).asInstanceOf[LinearThresholdUnit]
val ltu_predicted = baseClassifier.getLTU(LTU_predicted).asInstanceOf[LinearThresholdUnit]

if (ltu_actual != null)
ltu_actual.promote(a0, a1, 0.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are promoting/demoting by a fixed update of 0.1, shouldn't we take into account the learning rate parameter. The update rule inside LinearThresholdUnit's learn function is according to the learning rate and margin thickness.

Copy link
Member Author

@kordjamshidi kordjamshidi Nov 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this has remained here from my very first trial version. How should I pass the parameters, do you think that I just add it to the list of input parameters? Since we have two apply versions it can not have the default value for both cases as well, I guess. Isn't it a separate issue to have a consistent way for parameter setting in Saul?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseLTU already has all parameters to use. We can directly call the learn function to use those parameters.

val labelValues = a(3).asInstanceOf[Array[Double]]

if (ltu_actual != null) {
    # Learn as Positive Example
    ltu_actual.learn(a0, a1, Array(1), labelValues)
}

if (ltu_predicted != null) {
    # Learn as a negative example
    ltu_predicted.learn(a0, a1, Array(0), labelValues)
}

Also it might be better to rename all the variables a, a0, a1 etc for better readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call learn?! and what we are doing here then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

learn does not use internal prediction result?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/IllinoisCogComp/lbjava/blob/master/lbjava/src/main/java/edu/illinois/cs/cogcomp/lbjava/learn/LinearThresholdUnit.java#L462

Learn promotes or demotes the LTU's weight vector. The third argument controls if promote should be called or demote should be called.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the score, s?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine if we cannot use learn. My only concern was using that having a fixed learning rate might affect performance. We can fix that separately.

Expand All @@ -100,8 +105,13 @@ object JointTrainSparseNetwork {
trainOnce()
}
}

}
}
if (lossAugmented)
cls.foreach { cls_i =>
cls_i.onClassifier.classifier.unsetLossFlag()
}
}
train(node, cls, it - 1, false)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import scala.reflect.ClassTag

/** Created by parisakordjamshidi on 29/01/15.
*/
object JointTrain {
object JointTrainSparsePerceptron {
def testClassifiers(cls: Classifier, oracle: Classifier, ds: List[AnyRef]): Unit = {

val results = ds.map({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ object InitSparseNetwork {
//this means we are not reading any model into the SparseNetworks
// but we forget all the models and go over the data to build the right
// size for the lexicon and the right number of the ltu s

cClassifier.onClassifier.classifier.forget()
assert(cClassifier.onClassifier.classifier.getClass.getName.contains("SparseNetworkLearner"), "The classifier should be of type SparseNetworkLearner!")

val iLearner = cClassifier.onClassifier.classifier.asInstanceOf[SparseNetworkLearner]
allHeads.foreach {
head =>
Expand All @@ -33,7 +36,7 @@ object InitSparseNetwork {
if (label >= N || iLearner.getNetwork.get(label) == null) {
val isConjunctiveLabels = iLearner.isUsingConjunctiveLabels | iLearner.getLabelLexicon.lookupKey(label).isConjunctive
iLearner.setConjunctiveLabels(isConjunctiveLabels)
val ltu: LinearThresholdUnit = iLearner.getBaseLTU
val ltu: LinearThresholdUnit = iLearner.getBaseLTU.clone().asInstanceOf[LinearThresholdUnit]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the necessity for clone()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bug was caught by @bhargav, it needs to create a new instance of linear threshold here each time a new label is met. This was the main bug for the SparseNetwork initialization.

ltu.initialize(iLearner.getNumExamples, iLearner.getNumFeatures)
iLearner.getNetwork.set(label, ltu)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
/** This software is released under the University of Illinois/Research and Academic Use License. See
* the LICENSE file in the root folder for details. Copyright (c) 2016
*
* Developed by: The Cognitive Computations Group, University of Illinois at Urbana-Champaign
* http://cogcomp.cs.illinois.edu/
*/
package edu.illinois.cs.cogcomp.saul.classifier.JoinTrainingTests

import edu.illinois.cs.cogcomp.infer.ilp.OJalgoHook
Expand Down Expand Up @@ -71,7 +77,7 @@ class InitializeSparseNetwork extends FlatSpec with Matchers {
val wv1After = clNet1.getNetwork.get(0).asInstanceOf[LinearThresholdUnit].getWeightVector
val wv2After = clNet2.getNetwork.get(0).asInstanceOf[LinearThresholdUnit].getWeightVector

wv1After.size() should be(5)
wv1After.size() should be(6)
wv2After.size() should be(12)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/** This software is released under the University of Illinois/Research and Academic Use License. See
* the LICENSE file in the root folder for details. Copyright (c) 2016
*
* Developed by: The Cognitive Computations Group, University of Illinois at Urbana-Champaign
* http://cogcomp.cs.illinois.edu/
*/
package edu.illinois.cs.cogcomp.saulexamples.Badge;

import java.io.BufferedReader;
import java.io.FileInputStream;
import java.io.InputStreamReader;
import java.util.ArrayList;
import java.util.List;

public class BadgeReader {
public List<String> badges;

public BadgeReader(String dataFile) {
badges = new ArrayList<String>();

try {
BufferedReader br = new BufferedReader(new InputStreamReader(new FileInputStream(dataFile)));

String str;
while ((str = br.readLine()) != null) {
badges.add(str);
}

br.close();
}catch (Exception e) {}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the autoformatter on this file?

Loading