Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base types and their sensors #482

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Rahgooy
Copy link
Collaborator

@Rahgooy Rahgooy commented Jul 18, 2017

No description provided.

@Rahgooy
Copy link
Collaborator Author

Rahgooy commented Jul 18, 2017

These are the base classes that commonly used in NLP applications and their related sensors. I included a bit of code refactoring in this PR as well.

@kordjamshidi, please have a look.

# Saul NLP Base Types
Built in hierarchy of common linguistic units for processing text and NLP tasks
and a relation class that connects various linguistic units.
Nlp base types help to design data models in Saul and provide many built in feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built-in features

## Relation
Data modeling in Saul usually requires having edges between the model's nodes.
[Relations](Relation.java) help to have a container that holds the information
needed to construct those edges.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data modeling in Saul usually requires combining nodes and forming hypernodes.
+Relations help to have a container that holds the information
+needed to construct a flexible base type for this purpose. The programmer can establish edges between the new hypernode and other nodes which formed its parts explicitly if needed.
(Parisa: maybe some thing like this is a more clear explanation?)

boolean contains(ISpanElement e);
boolean isPartOf(ISpanElement e);
boolean overlaps(ISpanElement e);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the name ISpan..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a better suggestion? We talk about span-based elements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant why it starts with I?

Copy link
Collaborator Author

@Rahgooy Rahgooy Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then maybe SpanElementInterface? it is up to you but the name was confusing to me.

@kordjamshidi
Copy link
Member

A bit more documentation per file would be helpful. @bhargav @danyaljj please see if this will be helpful to simplify NLP for Saul and abstract things away from the details of textannotation. That has been the main goal of this PR.

@kordjamshidi kordjamshidi mentioned this pull request Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants