Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default web driver changed from Firefox to Chrome #327

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Aug 16, 2018

Description

Default web driver changed from Firefox to Chrome. Added RestProxyManager configuration file for local development (on vagrant). Added UpgradeNotes entry to explain the need to change RestProxyManager configuration in new AET version.

Motivation and Context

When some environment is using default settings or when someone starts a new AET instance (e.g. on vagrant), we want the tests to be working on Chrome web driver by default.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Adapted RestProxyManager configuration for Selenium Grid setup
- added UpgradeNotes entry
@tkaik tkaik requested a review from malaskowski August 16, 2018 10:13
Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update changelog?

@tkaik tkaik merged commit f72cd66 into milestone/chrome-support Aug 21, 2018
@tkaik tkaik deleted the feature/chrome-by-default branch August 21, 2018 09:04
@tkaik tkaik mentioned this pull request Aug 21, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants