Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone/chrome support #329

Merged
merged 53 commits into from
Aug 21, 2018
Merged

Milestone/chrome support #329

merged 53 commits into from
Aug 21, 2018

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Aug 21, 2018

Related PRs:
#294
#327

Description

  • Support for full page screenshot on Chrome driver
  • Integration tests - stabliziation and changes for Chrome
  • Default web driver changed from Firefox to Chrome

Motivation and Context

AET migration to Selenium Grid + Chrome driver

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

smoczysko88 and others added 30 commits July 18, 2018 12:44
@smoczysko88
Suite files udpated for chrome - line number changes, filter rules ch…
2a8dcb9 
…anges.

Removed form which caused screen comparator stabilization issues.
@Slasheruus
ChromeEntirePageScreen
ae0ac30
@smoczysko88
Merge remote-tracking branch 'origin/ChromeFullPageScreen' into bugfi…
cac7773 
…x/aet-integration-tests-stabilization
@PiteroS678
Chrome limit handler && disabled scrolling
8a6f67b
@PiteroS678
Refactoring
bc537b4
@PiteroS678
Tests for ResolutionModifier update
c3f9f4f
@smoczysko88
Setting resolution for chrome screen comparator
26772c8
@PiteroS678
Collect page height update
330a8a6
@smoczysko88
Merge remote-tracking branch 'origin/ChromeFullPageScreenNoScrolling'…
9ada174 
… into bugfix/aet-integration-tests-stabilization
@PiteroS678
Wiki - Hide Modifier update
834a837
@PiteroS678
Changed pageLoadStrategy && updated ResolutionModifierTest
e0120aa
@smoczysko88
Merge remote-tracking branch 'origin/ChromeFullPageScreenNoScrolling'…
49dbc7f 
… into bugfix/aet-integration-tests-stabilization
@tkaik
New chrome arg to fix headless+proxy screenshot issue
ed587b2
@smoczysko88
Merge remote-tracking branch 'origin/ChromeFullPageScreenNoScrolling'…
239dc4a 
… into bugfix/aet-integration-tests-stabilization
@PiteroS678
Revert pageLoadStrategy
503089f
@smoczysko88
Merge remote-tracking branch 'origin/ChromeFullPageScreenNoScrolling'…
863341b 
… into bugfix/aet-integration-tests-stabilization
@Slasheruus
Merge remote-tracking branch 'origin/task/w3c-nuvalidator-version-upg…
483662c 
…rade' into bugfix/aet-integration-tests-stabilization
@smoczysko88
Merge branch 'bugfix/aet-integration-tests-stabilization' of github.c…
6a0f420 
…om:Cognifide/aet into bugfix/aet-integration-tests-stabilization
@tkaik
Merge branch 'ChromeFullPageScreenNoScrolling' of https://github.com/…
7f3d41b 
…Cognifide/aet into bugfix/aet-integration-tests-stabilization
@smoczysko88
Merge branch 'bugfix/aet-integration-tests-stabilization' of github.c…
484381b 
…om:Cognifide/aet into bugfix/aet-integration-tests-stabilization
@PiteroS678
S-comparator-Layout-Hide-leaveBlankSpace-false - ResolutionModifier a…
a5fb1d9 
…fter HideModifier
@PiteroS678
ResolutionModifier - refactor
a2cff67
@tkaik
Decreased wait timeouts for tests stabilizations
2da4b7e
@PiteroS678
ResolutionModifier - refactor
b5b0eba
@PiteroS678
ResolutionModifierTest - update & refactor
b470103
@smoczysko88
Adjustments for Chrome compatibility
63de36c
@smoczysko88
Tests adjustments for chrome.
ac0178a
@PiteroS678
ResolutionModifierTest - new test & refactor,
69de42e 
ResolutionModifier - refactor
@tkaik
Increased cookie max age for tests stabilization
a85618f
@PiteroS678
ResolutionModifier - refactor
b2e2e1d
PiteroS678 and others added 20 commits July 31, 2018 12:19
@PiteroS678
ResolutionModifierTest - update
2cafbda
@PiteroS678
ResolutionModifierTest - refactor
80da189
@PiteroS678
Wiki - ResolutionModifier update
5f5e26c
@PiteroS678
layout.xml - new tests
0ae1f70
@PiteroS678
height_detection.jsp - minor fix
0af3bf3
@PiteroS678
Wiki - ResolutionModifier update
12e19a9
@PiteroS678
Wiki - HideModifier update
499442c
@PiteroS678
ResolutionModifier update
864f783
@plutasnyy
updated changelog
0ba974f
@plutasnyy
Merge branch 'milestone/chrome-support' into bugfix/aet-integration-t…
4533475 
…ests-stabilization
@Skejven
Merge pull request #294 from Cognifide/bugfix/aet-integration-tests-s…
5d12f34 
…tabilization

Full page screenshot support in Chrome
@malaskowski
Merge remote-tracking branch 'origin/master' into milestone/chrome-su…
dc9b2f7 
…pport
@tkaik
Timeout-based integration tests stabilization
fb295a8 
Modified timeouts on Sample Site and Test Suite
to fix tests results for SeleniumGrid+Chrome migration.
Updated functional tests
@tkaik
Merge pull request #304 from Cognifide/bugfix/timeout-based-tests-sta…
c0e606d 
…bilization

Timeout-based integration tests stabilization for Chrome
@tkaik
Merge branch 'master' of https://github.com/Cognifide/aet into milest…
fa79542 
…one/chrome-support

# Conflicts:
#	CHANGELOG.md
#	integration-tests/sanity-functional/src/test/java/com/cognifide/aet/sanity/functional/HomePageTilesTest.java
@tkaik
Merge branch 'master' of https://github.com/Cognifide/aet into milest…
1491f4f 
…one/chrome-support
@tkaik
Merge branch 'master' of https://github.com/Cognifide/aet into milest…
cfd71e0 
…one/chrome-support

# Conflicts:
#	CHANGELOG.md
#	integration-tests/sanity-functional/src/test/java/com/cognifide/aet/sanity/functional/HomePageTilesTest.java
#	integration-tests/sanity-functional/src/test/resources/features/filtering.feature
#	integration-tests/test-suite/partials/layout.xml
@tkaik
Default web driver changed from Firefox to Chrome.
331973b 
Adapted RestProxyManager configuration for Selenium Grid setup
- added UpgradeNotes entry
@tkaik
Updated Changelog - default webriver set to Chrome
b03c068
@tkaik
Merge pull request #327 from Cognifide/feature/chrome-by-default
f72cd66 
Default web driver changed from Firefox to Chrome
@tkaik tkaik requested a review from malaskowski August 21, 2018 09:52
@tkaik
Merge branch 'master' of https://github.com/Cognifide/aet into milest…
b68c0cd 
…one/chrome-support

# Conflicts:
#	CHANGELOG.md
#	core/worker/src/main/java/com/cognifide/aet/worker/drivers/WebDriverProvider.java
#	core/worker/src/main/java/com/cognifide/aet/worker/drivers/chrome/ChromeWebDriverFactory.java
#	documentation/src/main/wiki/UpgradeNotes.md
@tkaik
Minor fixes in new OSGI annotations
100e889
@tkaik tkaik merged commit 3bcac13 into master Aug 21, 2018
@wiiitek wiiitek deleted the milestone/chrome-support branch October 13, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malaskowski malaskowski malaskowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tkaik @malaskowski @smoczysko88 @Slasheruus @PiteroS678 @plutasnyy @Skejven