This repository has been archived by the owner on Nov 13, 2018. It is now read-only.
close old connections explicitly to prevent tcp conn leak #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1825
We found the tcp connections leak in traffic_stats 1.6.0. And verified the solution in 1.6.0.
The root cause is go "net/http" Client will keep idle connections for reuse. If we leave the influxDB client w/o explicitly close the transport, go GC could not re-collect the resources.
Please refer to influxdata/influxdb#6425
Not sure why the recent code in master discard the original logic to re-use influxDB client like traffic_stats 1.6.0. But anyway, we need to close old client explicitly. Otherwise, there will be lots of tcp connections leak quickly.