Prevent InfluxDB client from leaking TCP connections #6425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs changelog entry, but 👍 |
If users properly call client.Close(), then this will make sure that established tcp connections dont continually grow when creating new http clients. This fixes the case where users are creating new http clients on top of existing _valid_ connections. This was encountered in Telegraf when we were recreating our http clients after getting write failures that were unrelated to the actual connection being severed (such as typos in the retention policy, see influxdata/telegraf#1058)
sparrc
added a commit
to influxdata/telegraf
that referenced
this pull request
Apr 19, 2016
closes #1058 closes #1059 also see influxdata/influxdb#6425
This was referenced Apr 25, 2016
This was referenced Apr 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
If users properly call client.Close(), then this will make sure that
established tcp connections dont continually grow when creating new http
clients.
This fixes the case where users are creating new http clients on top of
existing valid connections.
This was encountered in Telegraf when we were recreating our http
clients after getting write failures that were unrelated to the actual
connection being severed (such as typos in the retention policy, see
influxdata/telegraf#1058)