Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListDetailsView: unfocus details on selection changed #4222

Closed
wants to merge 1 commit into from
Closed

ListDetailsView: unfocus details on selection changed #4222

wants to merge 1 commit into from

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Sep 2, 2021

Fixes #3546 #4244

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Sep 2, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi September 2, 2021 17:13
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Sep 2, 2021
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Sep 2, 2021

Working on writing unit tests for this. Note: As of 0c7cf48 its not working yet.

@michael-hawker michael-hawker added this to the 7.1 milestone Sep 7, 2021
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Sep 8, 2021

Got it working as of bb6233e, just need to write tests and see if it can simplified.

@Rosuavio Rosuavio changed the title ListDetailsView: unfocuse all children in details on selection changed ListDetailsView: unfocuse details on selection changed Sep 10, 2021
[TestClass]
public class Test_ListDetailsView_UI : VisualUITestBase
{
private const string sampleXaml = @"<controls:ListDetailsView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StyleCop: D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView_UI.cs(21,30): error SA1303: Const field names should begin with upper-case letter. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]

@XAML-Knight XAML-Knight self-assigned this Sep 30, 2021
@XAML-Knight XAML-Knight changed the title ListDetailsView: unfocuse details on selection changed ListDetailsView: unfocus details on selection changed Oct 1, 2021
@XAML-Knight
Copy link
Contributor

I inherited this PR, after @RosarioPulella sailed away on a new venture.

Let's scorecard where we are with ListDetailsView:

@Rosuavio Rosuavio closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListDetailsView navigation data loss
3 participants