-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListDetailsView: unfocus details on selection changed #4222
ListDetailsView: unfocus details on selection changed #4222
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Working on writing unit tests for this. Note: As of 0c7cf48 its not working yet. |
Got it working as of bb6233e, just need to write tests and see if it can simplified. |
[TestClass] | ||
public class Test_ListDetailsView_UI : VisualUITestBase | ||
{ | ||
private const string sampleXaml = @"<controls:ListDetailsView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StyleCop: D:\a\1\s\UnitTests\UnitTests.UWP\UI\Controls\Test_ListDetailsView_UI.cs(21,30): error SA1303: Const field names should begin with upper-case letter. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
I inherited this PR, after @RosarioPulella sailed away on a new venture. Let's scorecard where we are with ListDetailsView:
|
Fixes #3546 #4244
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information