Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListDetailsView unfocus content on SelectedIndex changed. #4255

Merged
merged 4 commits into from
Sep 16, 2021
Merged

ListDetailsView unfocus content on SelectedIndex changed. #4255

merged 4 commits into from
Sep 16, 2021

Conversation

Rosuavio
Copy link
Contributor

Fixes #4244 Also un-focuses content when SelectedIndex is changed.

Makes sure that the details of the list details view is get un-selected when the SelectedIndex is updated directly.

Note: This does not completely fix #3546, which would need to unfocus the details when the user clicks another item in the list. See #4222

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Sep 16, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from michael-hawker September 16, 2021 17:40
@Rosuavio Rosuavio added the bug 🐛 An unexpected issue that highlights incorrect behavior label Sep 16, 2021
@ghost ghost requested a review from azchohfi September 16, 2021 17:40
@Rosuavio Rosuavio added this to the 7.1 milestone Sep 16, 2021
@ghost ghost added the controls 🎛️ label Sep 16, 2021
@michael-hawker
Copy link
Member

Smoketest failure was just the transient failing to find the correct NuGet package one... Kicked it off again.

Copy link
Contributor

@XAML-Knight XAML-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests passed, when ran via build script


[TestCategory("ListDetailsView")]
[TestMethod]
public async Task Test_LoseFocusOnNoSelection()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When first running both of these unit tests, they both failed. After running each of them in the Visual Studio debugger, and having them fail, again, they finally did pass, after the next pass.

@Rosuavio
Copy link
Contributor Author

@XAML-Knight @michael-hawker I updated the tests, they should run more constantly now.

@ghost
Copy link

ghost commented Sep 16, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 48 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker merged commit e146ab5 into CommunityToolkit:main Sep 16, 2021
@Rosuavio Rosuavio deleted the bugfix/listdetailsview-unfocus-content branch September 20, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️
Projects
None yet
3 participants