-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListDetailsView unfocus content on SelectedIndex changed. #4255
ListDetailsView unfocus content on SelectedIndex changed. #4255
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Smoketest failure was just the transient failing to find the correct NuGet package one... Kicked it off again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests passed, when ran via build script
|
||
[TestCategory("ListDetailsView")] | ||
[TestMethod] | ||
public async Task Test_LoseFocusOnNoSelection() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When first running both of these unit tests, they both failed. After running each of them in the Visual Studio debugger, and having them fail, again, they finally did pass, after the next pass.
@XAML-Knight @michael-hawker I updated the tests, they should run more constantly now. |
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 48 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #4244 Also un-focuses content when SelectedIndex is changed.
Makes sure that the details of the list details view is get un-selected when the SelectedIndex is updated directly.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information