Remove unused parameter model name in _get_model_script_db() #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellis13
added
type: refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #477 +/- ##
========================================
Coverage 78.82% 78.82%
========================================
Files 97 97
Lines 7362 7362
========================================
Hits 5803 5803
Misses 1559 1559
|
ashao
approved these changes
Apr 8, 2024
ashao
approved these changes
Apr 8, 2024
amandarichardsonn
added
API break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unused parameter in
RedisCluster::_get_model_script_db(). The comments for the function were also corrected to reflect the actual behavior of the function. It is worth noting that _get_model_script_db is not called currently in SmartRedis, but it was not removed because it was a precursor implementation for optimizing model execution.