Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter model name in _get_model_script_db() #477

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove unused parameter model name in _get_model_script_db() #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604d705
Remove unused parameter model name in the _get_model_scrit_db()
mellis13 Apr 7, 2024
1354021
Add changelog entry.
mellis13 Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,20 @@ To be released at some future point in time

Description

- Remove unused parameter in internal redis cluster method
- Update CI for Intel suite
- Fix inconsistency in C-API ConfigOptions is_configured() parameters

Detailed Notes

- Removes an unused parameter in the RedisCluster::_get_model_script_db()
method. (PR477_)
- Version numbers changed for the Intel Compiler chain that lead to the C and C++
compilers not being available. Now, the entirety of the Base and HPC kits are
installed to ensure consistent versions. (PR475_)
- Fix an inconsistency in the C-API ConfigOptions is_configured() parameter names. (PR471_)

.. _PR477: https://github.com/CrayLabs/SmartRedis/pull/477
.. _PR475: https://github.com/CrayLabs/SmartRedis/pull/475
.. _PR471: https://github.com/CrayLabs/SmartRedis/pull/471

Expand Down
11 changes: 6 additions & 5 deletions include/rediscluster.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,16 +738,17 @@ class RedisCluster : public RedisServer
std::vector<std::string> outputs);

/*!
* \brief Retrieve the optimum model prefix for
* the set of inputs
* \param name The name of the model
* \brief Retrieve the db node in the cluster that contains
* the most input and output tensors. If multiple
* db nodes contain the same amount of input and
* output tensors, the first db node in the internal
* data structure is returned.
* \param inputs The keys of inputs tensors to use
* in the model
* \param outputs The keys of output tensors that
* will be used to save model results
*/
DBNode* _get_model_script_db(const std::string& name,
std::vector<std::string>& inputs,
DBNode* _get_model_script_db(std::vector<std::string>& inputs,
std::vector<std::string>& outputs);

/*!
Expand Down
11 changes: 5 additions & 6 deletions src/cpp/rediscluster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,14 +1410,13 @@
(void)run(cmd);
}

// Retrieve the optimum model prefix for the set of inputs
DBNode* RedisCluster::_get_model_script_db(const std::string& name,
std::vector<std::string>& inputs,
// Retrieve the optimum db node for model and script execution
DBNode* RedisCluster::_get_model_script_db(std::vector<std::string>& inputs,

Check warning on line 1414 in src/cpp/rediscluster.cpp

View check run for this annotation

Codecov / codecov/patch

src/cpp/rediscluster.cpp#L1414 

Added line #L1414 was not covered by tests
std::vector<std::string>& outputs)
{
/* This function calculates the optimal model name to use
to run the provided inputs. If a cluster is not being used,
the model name is returned, else a prefixed model name is returned.
/* This function determines which db node in the cluster
contains the most input and output tensors and
returns a pointer to that db node.
*/

// TODO we should randomly choose the max if there are multiple maxes
Expand Down
Loading