Discontinue SmartRedis support for python 3.8 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 9, 2024 16:39
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #482 +/- ##
============================================
+ Coverage 78.84% 95.92% +17.08%
============================================
Files 97 10 -87
Lines 7369 884 -6485
============================================
- Hits 5810 848 -4962
+ Misses 1559 36 -1523 |
mellis13
reviewed
Apr 17, 2024
MattToast
reviewed
Apr 17, 2024
ashao
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
No comments other than the ones that @MattToast and @mellis13 picked up on. Only other request is to put up a ticket explaining where bumping to Ubuntu 22.04 in the other actions failed
amandarichardsonn
added
the
API break
amandarichardsonn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is no longer going to be supported because it's near end of life. I've gone through and removed/updated everything that I could find! I added no-merge because I am not sure if there's a specific order that we need to merge all the repos.