Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue SmartRedis support for python 3.8 #482

Merged
merged 14 commits into from
Apr 17, 2024
Merged
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
strategy:
fail-fast: true
matrix:
os: [ubuntu-20.04] # cannot test on macOS as docker isn't supported on Mac
rai_v: [1.2.4, 1.2.5] # verisons of RedisAI
os: [ubuntu-22.04] # cannot test on macOS as docker isn't supported on Mac
rai_v: [1.2.5] # verisons of RedisAI

# Service containers to run with docker tests
services:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
- uses: actions/setup-python@v2
name: Install Python
with:
python-version: '3.8'
python-version: '3.9'

- name: Build sdist
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
matrix:
os: [ubuntu-22.04] # cannot test on macOS as docker isn't supported on Mac
rai_v: [1.2.7] # versions of RedisAI
py_v: ['3.8.x', '3.9.x', '3.10.x', '3.11.x'] # versions of Python
py_v: ['3.9.x', '3.10.x', '3.11.x'] # versions of Python
compiler: [nvhpc-23-11, intel-2024.0, gcc-11, gcc-12] # intel compiler, and versions of GNU compiler
link_type: [Static, Shared]
env:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ SmartRedis provides clients in the following languages:

| Language | Version/Standard |
|------------|:----------------------------------------------:|
| Python | 3.8, 3.9, 3.10, 3.11 |
| Python | 3.9, 3.10, 3.11 |
| C++ | C++17 |
AlyssaCote marked this conversation as resolved.
Show resolved Hide resolved
| C | C99 |
| Fortran | Fortran 2018 (GNU/Intel), 2003 (PGI/Nvidia) |
Expand Down
4 changes: 4 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To be released at some future point in time

Description

- Drop Python 3.8 support
- Fix C++ cosmetic defects leading to compiler warnings
- Enforce changelog updates
- Removed unused TensorBase constructor parameter
Expand All @@ -18,6 +19,8 @@ Description

Detailed Notes

- Python 3.8 is reaching its end-of-life in October, 2024, so it will
no longer continue to be supported. (PR482_)
- Fixes some mainly cosmetic defects in the C++ client that were leading to warnings
when pedantic compiler flags were enabled (PR476_)
- Re-enable SR_PEDANTIC for the `test-lib` and `test-lib-with-fortran` Makefile targets (PR476_)
Expand All @@ -35,6 +38,7 @@ Detailed Notes
installed to ensure consistent versions. (PR475_)
- Fix an inconsistency in the C-API ConfigOptions is_configured() parameter names. (PR471_)

.. _PR482: https://github.com/CrayLabs/SmartRedis/pull/482
.. _PR476: https://github.com/CrayLabs/SmartRedis/pull/476
.. _PR480: https://github.com/CrayLabs/SmartRedis/pull/480
.. _PR479: https://github.com/CrayLabs/SmartRedis/pull/479
Expand Down
2 changes: 1 addition & 1 deletion doc/overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ below summarizes the language standards for each client.
* - Language
- Version/Standard
* - Python
- 3.8-3.11
- 3.9-3.11
* - C++
- C++17
* - C
Expand Down
2 changes: 1 addition & 1 deletion images/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#

## Builder image
FROM ubuntu:20.04 as builder
FROM ubuntu:22.04 as builder

# Install tooling
RUN apt-get update && \
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"

[tool.black]
line-length = 88
target-version = ['py37', 'py38', 'py39', 'py310']
target-version = ['py39', 'py310']
AlyssaCote marked this conversation as resolved.
Show resolved Hide resolved
exclude = '''
(
| \.egg
Expand Down
3 changes: 1 addition & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ contact_email = [email protected]
license = BSD 2-Clause License
keywords = redis, clients, hpc, ai, deep learning
classifiers =
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Expand All @@ -34,7 +33,7 @@ setup_requires =
include_package_data = True
install_requires =
numpy>=1.18.2
python_requires = >=3.8,<3.12
python_requires = >=3.9,<3.12


[options.extras_require]
Expand Down
Loading