Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding null check for the rendering handler thread #813

Closed
wants to merge 1 commit into from

Conversation

pritamps
Copy link

@pritamps pritamps commented Sep 4, 2019

This will prevent the app from crashing if the rendering thread is null when the loading is complete

@babramovitch
Copy link

babramovitch commented Feb 13, 2020

This won't fix the problem, it will just crash a couple lines down when it attempts to access the looper

renderingHandler = new RenderingHandler(renderingHandlerThread.getLooper(), this);

@jlo1
Copy link

jlo1 commented Mar 6, 2020

This PR #824 should fix the issue.

@pritamps
Copy link
Author

pritamps commented Mar 7, 2020

Good point about the issue just being pushed further down with my attempted fix... And Thanks to @jlo1 for pointing out a fix to the actual issue!

@pritamps pritamps closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants