Move handler creation to onAttachedToWindow() instead of the constructor #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
grizzly
approved these changes
Nov 25, 2019
jlo1
approved these changes
Mar 6, 2020
|
@barteksc could you merge this fix and create a new release please? It's a big blocker for people using your library in React Native: https://github.com/wonday/react-native-pdf 😿 |
polesapart
added a commit
to polesapart/AndroidPdfViewer
that referenced
this pull request
Jul 11, 2020
Fix previous merge
|
Is this update added in V3.2.0-beta.1? I am getting crash for this issue. |
mhiew
added a commit
to mhiew/AndroidPdfViewer
that referenced
this pull request
Dec 27, 2021
- the thread creation and recycling was not being handled symmetrically - this fix is based off of these two PR: DImuthuUpe#824 and #2
AhmerAfzal1
added a commit
to AhmerAfzal1/AhmerPdfium
that referenced
this pull request
Feb 14, 2022
Fix a potential NPE due to out of sync render thread management [Pull Request](DImuthuUpe/AndroidPdfViewer#824) Update the sample app configuration so that it can compile [Pull Request](mhiew/AndroidPdfViewer#2)
|
Please add new feature for autoCropPageMargin on bitmap blank space |
ai-developer63
approved these changes
Feb 14, 2024
facundofernandez
added a commit
to facundofernandez/AndroidPdfViewer
that referenced
this pull request
Sep 13, 2024
- the thread creation and recycling was not being handled symmetrically - this fix is based off of these two PR: DImuthuUpe#824 and mhiew#2 ref: DImuthuUpe@41f912e
facundofernandez
added a commit
to GoIntegro/AndroidPdfViewer
that referenced
this pull request
Sep 16, 2024
- the thread creation and recycling was not being handled symmetrically - this fix is based off of these two PR: DImuthuUpe#824 and mhiew#2 ref: DImuthuUpe/AndroidPdfViewer@41f912e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detaching and reattaching a
PDFViewcauses an NPE. This is due to creating a handler in the constructor, but setting it to null inonDetachedFromWindow(). The fix is to create the handler ononAttachedToWindow()instead of the constructor.This allows the view to be detached and re-attached without loss of functionality.