Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain default sorting for tables when user clicks 'View all' #1214

Closed
stephaniesimms opened this issue Feb 23, 2018 · 5 comments
Closed

Retain default sorting for tables when user clicks 'View all' #1214

stephaniesimms opened this issue Feb 23, 2018 · 5 comments
Assignees
Labels
bug effort-medium 1/2 to 1 day of dev time

Comments

@stephaniesimms
Copy link

This is an outstanding part of issue #1187 - Default sorting was completed. But we still want to retain default sorting when user clicks 'View All' to expand the tables.

  • on My Dashboard: default sorting should be by plan 'Last edited' date, most recent first
  • all other tables: default sorting should be alphabetical by first field (Template Name, User Name, etc)
@briri briri added the effort-medium 1/2 to 1 day of dev time label Mar 7, 2018
@jollopre jollopre mentioned this issue Mar 23, 2018
jollopre pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Mar 26, 2018
…_params. DMPRoadmap#1214

ammended test for paginable concern. DMPRoadmap#1214

solving JS linter problems
@stephaniesimms
Copy link
Author

this doesn't appear to be working. when I click "View All" on plans tables on My Dashboard, DMP Templates, Public Plans, etc the sorting still changes. moving back to in progress.

@jollopre
Copy link
Contributor

@stephaniesimms I don't think the server has deployed any of this stuff yet

@stephaniesimms
Copy link
Author

clicking 'View All' retains default sort for all tables visible to logged-in users (plans, templates, etc). But this doesn't appear to be working for the DMP Templates or Public DMPs tables @jollopre

@jollopre
Copy link
Contributor

@stephaniesimms, any page that is 'paginable', i.e. has search, sorting and page links behaves in the same way. I have tried the two cases that you described and the sort is properly retained.

Your comment suggest 'default sorting' which indeed these two pages don't have and therefore you have to click to any sortable column to be retained. What is the default sorting you want to apply to these?

I would create a new issue to address the default sorting of these two views, since the retaining of the sorting I believe it works properly.

@stephaniesimms
Copy link
Author

thanks for the clarification @jollopre - i thought these tables had a default set, but it appears that they do not so i'll create an issue as you suggested. all other tables look good so i'll go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effort-medium 1/2 to 1 day of dev time
Projects
None yet
Development

No branches or pull requests

3 participants