Issue1214 #1324
Merged
Issue1214 #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks reasonable @jollopre. We will need to update the other views that use paginable to work with this. |
…_params. DMPRoadmap#1214 ammended test for paginable concern. DMPRoadmap#1214 solving JS linter problems
|
@briri thanks for reviewing. I've fixed the linter problems, the API method used across the views (e.g. paginable_sort_link) has not changed at all so therefore there is no need to update any view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored paginable concern to accommodate proper retaining of query_params. #1214
There are additional test cases that should be added but I plan to do it as part of #1186