Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE form broken on template edit page #1777

Closed
Bodacious opened this issue Aug 3, 2018 · 4 comments
Closed

TinyMCE form broken on template edit page #1777

Bodacious opened this issue Aug 3, 2018 · 4 comments
Labels
bug effort-medium 1/2 to 1 day of dev time

Comments

@Bodacious
Copy link
Contributor

Bodacious commented Aug 3, 2018

Please complete the following fields as applicable:

Expected behaviour:
When I add a new section to a template, the section's description field should load as a TinyMCE editor

Actual behaviour:
When I add a new section to a template, the section's description field loads as a standard HTML textarea with HTML inside.

Steps to reproduce:
Add a new section to a Template. NOTE: This doesn't seem to affect the existing sections that are loaded via AJAX

screen shot 2018-08-03 at 12 40 03

@Bodacious Bodacious added bug effort-medium 1/2 to 1 day of dev time labels Aug 3, 2018
@stephaniesimms
Copy link

stephaniesimms commented Aug 16, 2018

I just tested and when I create a new section the TinyMCE editor loads as expected, but after i enter a description and click Save i see the HTML area as reported above (screenshot below).

screen shot 2018-08-16 at 8 27 35 am

@sjDCC also noted the following
We had changed all text boxes to be TinyMCE but the section description box is reverting to the old style. I noticed this when adding section on the 'customise template' view, but see it's happening when you edit existing templates too
tinymce-box

@Bodacious
Copy link
Contributor Author

Bodacious commented Aug 20, 2018

Hi @stephaniesimms

I noticed that issue with the forms not loading as proper TinyMCE a few days ago.

Fixed today as part of ff51187

@stephaniesimms
Copy link

thanks @Bodacious - we both noticed it too while testing. will check again once it's deployed.

xsrust pushed a commit that referenced this issue Aug 22, 2018
* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem
@sjDCC
Copy link
Contributor

sjDCC commented Aug 22, 2018

Looks good now. Closing out

@sjDCC sjDCC closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effort-medium 1/2 to 1 day of dev time
Projects
None yet
Development

No branches or pull requests

3 participants