Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TinyMCE JS on forms loaded with DOM #1827

Merged
merged 4 commits into from
Aug 22, 2018
Merged

Fix TinyMCE JS on forms loaded with DOM #1827

merged 4 commits into from
Aug 22, 2018

Conversation

Bodacious
Copy link
Contributor

Fixes #1777

Changes proposed in this PR:

  • Fixed certain cases where blank annotations were still raising save errors
  • Fixed bug preventing TinyMCE from loading properly when section included in initial page load
  • Fixed bug preventing TinyMCE from loading properly when question included in initial page load

@Bodacious Bodacious requested review from briri and xsrust August 20, 2018 18:00
@Bodacious
Fix broken specs
10be9f8
@Bodacious
Fix Rubocop style violations
f3f750c 
Ignored LineLength violations when string is part of FastGettext
@Bodacious
Updated rubocop style gem
aa90044
xsrust
xsrust approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@xsrust xsrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpful that you've separated out the commits to reduce review noise with the rubocop updates.

@xsrust xsrust merged commit 7dcb85e into development Aug 22, 2018
@briri briri deleted the bug/template-editing branch January 22, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsrust xsrust xsrust approved these changes

@briri briri Awaiting requested review from briri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bodacious @xsrust