Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS issues #1805

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Fix JS issues #1805

merged 1 commit into from
Aug 22, 2018

Conversation

briri
Copy link
Contributor

@briri briri commented Aug 14, 2018

Fixes #1804.

@briri briri force-pushed the issue1778 branch 2 times, most recently from 283dda0 to ec64be1 Compare August 14, 2018 20:44
@briri
Copy link
Contributor Author

briri commented Aug 14, 2018

Hold off on merging this one. I'm in the process of running the data cleanup scripts and unable to run the tests locally to trace down and resolve the Travis errors. Will address it tomorrow

@Bodacious
Copy link
Contributor

@briri Rebase this on development once #1810 has been merged in. That oughtta fix it.

@briri briri force-pushed the issue1778 branch 2 times, most recently from 1c611a0 to 18794ed Compare August 15, 2018 18:29
@briri
Copy link
Contributor Author

briri commented Aug 15, 2018

Thanks for the update in #1810 @Bodacious. I updated it further to make sure this new Org selection logic is pulled into the following pages:

  • ShibbolethDS (I think DMPTool is the only one using this)
  • User profile page
  • User edit (Super Admin)

updates to JS for org selection cahnges in PR#1778
@xsrust xsrust merged commit 20356ff into DMPRoadmap:development Aug 22, 2018
@briri briri deleted the issue1778 branch September 26, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants