Fix bug preventing orgs loading on register page #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent updates to the DB have made the `is_other` field on the Orgs table mandatory. Previously, it was loading null values. This PR updates this to load false values instead. Fixes #1809
Merged
Bodacious
commented
Aug 15, 2018
| @@ -15,7 +15,7 @@ namespace :assets do | |||
| # Ensure all dependencies are installed | |||
| system("npm install") | |||
| # Run the webpack command via npm | |||
| system("npm run bundle -- #{webpack_options.join(" ")}") | |||
| system("npm run bundle -- #{webpack_options.join(" ")}") or exit() | |||
There was a problem hiding this comment.
@briri This should ensure Travis fails early if the webpack script doesn't compile properly
|
Should help with #1804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent updates to the DB have made the
is_otherfield on the Orgs table mandatory.Previously, it was loading null values. This PR updates this to load false values instead.
Fixes #1809
Changes proposed in this PR:
is_otheris false, instead of null