Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toggleable guidance/comments section #3123

Merged

Conversation

benjaminfaure
Copy link
Contributor

Changes proposed in this PR:

  • Add toggleable comments/guidance section
    • add config to enable/disable this feature
    • add config to open/close by default
    • question/guidance divs use flexbox instead of bootstrap grid system

@benjaminfaure
Copy link
Contributor Author

I wasn't sure where to put the CSS & JS code, if it's in the wrong place please tell me :)

Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this to us so quickly @benjaminfaure!

I have 2 very minor changes. It looks great overall and the JS and SCSS files are in the correct place! :)

I will pull down the changes and confirm that it works as expected in the UI later today

config/initializers/_dmproadmap.rb Outdated Show resolved Hide resolved
app/views/phases/_edit_plan_answers.html.erb Outdated Show resolved Hide resolved
@benjaminfaure
Copy link
Contributor Author

Thanks for your feedback @briri , I push the changes you requested :)

@raycarrick-ed
Copy link
Contributor

@benjaminfaure @briri Pulled down the code on top of an up to date roadmap and it worked perfectly out of the box. Very nice! So I'm for it to get merged in.

@briri briri merged commit 832eae0 into DMPRoadmap:development Mar 11, 2022
@benjaminfaure benjaminfaure deleted the feature/toggeable_comments_section branch March 14, 2022 08:45
@briri briri mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants