changes for v3.0.7 #3146
Merged
changes for v3.0.7 #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests added tests for new external_api services Added test for new presenter change migration classname fixes for rubocop and rspec offerings to the rubocop gods cleanup of unused code and added config for license opts fixed tests cleaned up schema Fix for postgres regex matching Fix for postgres regex matching trying to fix postgres updated config to disable research_outputs by default updated plans_controller to work with new Plan.grant setter method removed debug lines fixed typo in plan model and added dependent destroy on a few associations removed debug lines fixed bug in v1 api due to removed Plan.api_client column updated plan spec factory so that :creator ensures the owner's org matches the plan.org added api_client association back to plans model. Added some Mysql vs Postgres helper methods to the ApplicationRecord base class making rubocop happy fix typo making rubocop happy trying to fix postgres :/ Hopefully fibally fixed postgres Hopefully fibally fixed postgres Hopefully fibally fixed postgres
…p-research-outputs
…p into madmp-research-outputs
failing in the REST API V1 call "GET 0/api/v1/plans" for following reasons: (1) Plans policy initialize method was broken (2) Each plan in the json array was using the email for the user name. DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/697 Changes made: (1) The initialize method in /policies/api/v1/plans super call requires no arguments, it was taking the ApiClient as an argument. (2) In /views/api/v1/contributors/_show.json.jbuilder we changed json.name as follows as we were previously using the 'User' rather than 'Contributor' object json.name contributor.is_a?(User) ? contributor.name(false) : contributor.name
…isplaying_email_for_name DCC bug 697 - Fix for a roadmap-wide bug where the following were
fix issue with display of org links and email
fields on Contributor edit page. Fix for issue #2983 Changes: - Removed aria: {required: true} from input tags for name and email.
…owing_both_email_and_name_required_wrongly Issue #2983 - Removed wrongly displayed required * for name and email
Updated schema.rb to have the timestamp of the new migration
New maDMP Research Outputs tab
Dependency updates
…desk_email_property DCC Feature #345 - Allow Orgs to set a different Help Desk Email Address
…dmap into fix_unpublish_template
updated translations for v3.0.7
proposal to avoid used unpublished templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate for v3.0.7
Changes proposed in this PR:
config/initializers/_dmproadmap.rbthat allows you to set whether or not the section is collapsed on page load ... default if 'false')bin/rails external_api:add_field_of_science_to_research_domains RAILS_ENV=[env]to initialize the table with data)config/initializers/_dmproadmap.rbthat allow you to enable/disable each component. They are all disabled by default)bin/rails external_api:load_rdamsc_standards RAILS_ENV=[env]to initialize the table with data)bin/rails external_api:load_spdx_licenses RAILS_ENV=[env]to initialize the table with data)bin/rails external_api:load_re3data_repos RAILS_ENV=[env]to initialize the table with data)app/views/layouts/modal_searchdir to help describe how to implement)services/external_apisthat fetch data for the License, Metadata Standard and Repository tablesSome %{variable_name} textRevert string format token changes made for Rubocop #3128Screenshot of the new collapsible guidance/comments section:
Screenshot of the new Research Outputs tab:
Screenshot of new Modal window that allows user to select a Repository (functionality for Metadata Standards is similar):
Screenshot of new JSON Output (also delivered by API v1) showing a Research Output translated into the RDA Common Standard:
Screenshot of Research Outputs as an addendum to the PDF:
