Revert string format token changes made for Rubocop #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @benjaminfaure and @hbayindir |
|
brakeman issue is just a deprecation warning about Ruby 2.6.3 EOL which we are aware of |
|
Changes all look fine. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched the way we handle string formatting tokens when we upgraded Rubocop. Rubocop's new default is to use
%<variable>sinstead of%{variable}.This has caused quite a bit of confusion for our translators, and I discovered today that Translation.io is not properly auto-translating these. It takes
%<variable>s some textand translates it to%<variable> s un peu de texte. Note the space between the closing bracket '>' and the 's' character.This update reverts the changes we made to use
%<variable>sand updates the.rubocop.ymlfile to enforce use of thetemplatestyle,%{variable}going forward.Once merged, translations will need to be resynced!