Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Edit -> Collection" by restoring ngOnInit() method which was accidentally removed #2329

Closed
wants to merge 1 commit into from

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Jun 21, 2023

References

Description

Restores the ngOnInit() method to collection-form.component.ts which was accidentally removed in #2308

Instructions for Reviewers

  • Verify Collection creation page is not rendered DSpace#8911 no longer reproducible
    • Login as an Admin
    • Go to "New -> Collection". Select a Community to add the Collection in
    • Verify the Collection form loads now, and verify that it allows you to create a Collection.

@tdonohue tdonohue added bug high priority 1 APPROVAL pull request only requires a single approval to merge labels Jun 21, 2023
@tdonohue tdonohue added this to the 7.6 milestone Jun 21, 2023
@tdonohue tdonohue self-assigned this Jun 21, 2023
@tdonohue
Copy link
Member Author

@atarix83 or @alisaismailati : Could you or someone on your team give this a quick look? It seems to have been accidentally caused by #2308 (which was merged last week)

@tdonohue tdonohue requested a review from atarix83 June 21, 2023 20:56
@alisaismailati
Copy link
Contributor

Hi @tdonohue ,
I will have a look at this task.

@alisaismailati alisaismailati mentioned this pull request Jun 22, 2023
8 tasks
@tdonohue
Copy link
Member Author

Closing, replaced by #2332

@tdonohue tdonohue closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection creation page is not rendered
2 participants