Merge pull request #2271 from DataDog/mconstantin/small-api-fix-addvi…

…ewloadingtime Do not use magic numbers in InternalLogger API
DataDog · Sep 20, 2024 · a0463ad · a0463ad
2 parents a6bd6a5 + 8038b2f
commit a0463ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/dd-sdk-android-core/api/apiSurface b/dd-sdk-android-core/api/apiSurface
@@ -44,7 +44,7 @@ interface com.datadog.android.api.InternalLogger
   fun log(Level, List<Target>, () -> String, Throwable? = null, Boolean = false, Map<String, Any?>? = null)
   fun logMetric(() -> String, Map<String, Any?>, Float)
   fun startPerformanceMeasure(String, com.datadog.android.core.metrics.TelemetryMetricType, Float, String): com.datadog.android.core.metrics.PerformanceMetric?
-  fun logApiUsage(com.datadog.android.internal.telemetry.InternalTelemetryEvent.ApiUsage, Float = 15f)
+  fun logApiUsage(com.datadog.android.internal.telemetry.InternalTelemetryEvent.ApiUsage, Float = DEFAULT_API_USAGE_TELEMETRY_SAMPLING_RATE)
   companion object 
     val UNBOUND: InternalLogger
 interface com.datadog.android.api.SdkCore

diff --git a/dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/InternalLogger.kt b/dd-sdk-android-core/src/main/kotlin/com/datadog/android/api/InternalLogger.kt
@@ -142,11 +142,13 @@ interface InternalLogger {
     @InternalApi
     fun logApiUsage(
         apiUsageEvent: InternalTelemetryEvent.ApiUsage,
-        samplingRate: Float = 15f
+        samplingRate: Float = DEFAULT_API_USAGE_TELEMETRY_SAMPLING_RATE
     )
 
     companion object {
 
+        private const val DEFAULT_API_USAGE_TELEMETRY_SAMPLING_RATE = 15f
+
         /**
          * Logger for the cases when SDK instance is not yet available. Try to use the logger
          * provided by [FeatureSdkCore.internalLogger] instead if possible.