Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use magic numbers in InternalLogger API #2271

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 requested review from a team as code owners September 19, 2024 14:52
@mariusc83 mariusc83 force-pushed the mconstantin/small-api-fix-addviewloadingtime branch from ab17e2a to 8038b2f Compare September 19, 2024 15:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (529e791) to head (8038b2f).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...n/kotlin/com/datadog/android/api/InternalLogger.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2271      +/-   ##
===========================================
+ Coverage    69.98%   70.02%   +0.04%     
===========================================
  Files          731      731              
  Lines        27204    27211       +7     
  Branches      4574     4577       +3     
===========================================
+ Hits         19037    19053      +16     
+ Misses        6896     6874      -22     
- Partials      1271     1284      +13     
Files with missing lines Coverage Δ
...n/kotlin/com/datadog/android/api/InternalLogger.kt 93.75% <0.00%> (ø)

... and 31 files with indirect coverage changes

@mariusc83 mariusc83 merged commit a0463ad into develop Sep 20, 2024
23 checks passed
@mariusc83 mariusc83 deleted the mconstantin/small-api-fix-addviewloadingtime branch September 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants