Merge pull request #38 from DeKal/add-home-id

Fix bug Home components doesn't have id to navigate to #37
DeKal · Dec 3, 2019 · 0eb6e35 · 0eb6e35 · vercel · Dec 3, 2019
2 parents 057ddf6 + 553f975
commit 0eb6e35
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/views/components/Home.js b/views/components/Home.js
@@ -1,9 +1,9 @@
 import * as React from 'react'
-
+import { HOME } from '~/consts/pages'
 import styled from 'styled-components/macro'
 
 const Home = () => (
-  <HomeSection>
+  <HomeSection id={HOME}>
     <Background />
     <Overlay>
       <div className="container">

diff --git a/views/components/__test__/__snapshots__/Home.spec.tsx.snap b/views/components/__test__/__snapshots__/Home.spec.tsx.snap
@@ -2,7 +2,9 @@
 
 exports[`Home should render without throwing an error 1`] = `
 <Home>
-  <Home__HomeSection>
+  <Home__HomeSection
+    id="Home"
+  >
     <StyledComponent
       forwardedComponent={
         Object {
@@ -29,9 +31,11 @@ exports[`Home should render without throwing an error 1`] = `
         }
       }
       forwardedRef={null}
+      id="Home"
     >
       <section
         className="Home__HomeSection-sc-1eskvms-0 blNagb"
+        id="Home"
       >
         <Home__Background>
           <StyledComponent